Skip to content

Run stylelint on .vue files #24865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2023
Merged

Run stylelint on .vue files #24865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a61cd
Run stylelint on .vue files
silverwind May 22, 2023
da9cb47
Merge branch 'main' into slvue
GiteaBot May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .stylelintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ overrides:
- files: ["**/chroma/*", "**/codemirror/*"]
rules:
block-no-empty: null
- files: ["**/*.vue"]
customSyntax: postcss-html

rules:
alpha-value-notation: null
Expand Down Expand Up @@ -96,7 +98,7 @@ rules:
property-no-vendor-prefix: null
rule-empty-line-before: null
rule-selector-property-disallowed-list: null
scale-unlimited/declaration-strict-value: [[color, background-color, border-color, font-weight], {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor|none)$/, ignoreFunctions: false}]
scale-unlimited/declaration-strict-value: [[color, background-color, border-color, font-weight], {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor|none)$/, ignoreFunctions: false, disableFix: true}]
selector-attribute-name-disallowed-list: null
selector-attribute-operator-allowed-list: null
selector-attribute-operator-disallowed-list: null
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,11 +372,11 @@ lint-js-fix: node_modules

.PHONY: lint-css
lint-css: node_modules
npx stylelint --color --max-warnings=0 web_src/css
npx stylelint --color --max-warnings=0 web_src/css web_src/js/components/*.vue

.PHONY: lint-css-fix
lint-css-fix: node_modules
npx stylelint --color --max-warnings=0 web_src/css --fix
npx stylelint --color --max-warnings=0 web_src/css web_src/js/components/*.vue --fix

.PHONY: lint-swagger
lint-swagger: node_modules
Expand Down
53 changes: 53 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"eslint-plugin-wc": "1.5.0",
"jsdom": "22.0.0",
"markdownlint-cli": "0.34.0",
"postcss-html": "1.5.0",
"stylelint": "15.6.2",
"stylelint-declaration-strict-value": "1.9.2",
"svgo": "3.0.2",
Expand Down
14 changes: 7 additions & 7 deletions web_src/js/components/RepoActionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ export function ansiLogToHTML(line) {
/* action view header */

.action-view-header {
margin: 20px 0px;
margin: 20px 0;
}

.action-info-summary {
Expand All @@ -452,7 +452,7 @@ export function ansiLogToHTML(line) {
.action-commit-summary {
display: flex;
gap: 5px;
margin: 10px 0px 10px 25px;
margin: 10px 0 10px 25px;
}

/* ================ */
Expand All @@ -472,7 +472,7 @@ export function ansiLogToHTML(line) {
.job-artifacts-title {
font-size: 18px;
margin-top: 16px;
padding: 16px 10px 0px 20px;
padding: 16px 10px 0 20px;
border-top: 1px solid var(--color-secondary);
}

Expand Down Expand Up @@ -639,8 +639,8 @@ export function ansiLogToHTML(line) {
}

.job-step-section .job-step-logs {
font-family: monospace, monospace;
margin: 8px 0px;
font-family: monospace;
margin: 8px 0;
font-size: 12px;
}

Expand Down Expand Up @@ -673,7 +673,7 @@ export function ansiLogToHTML(line) {
margin-left: 10px;
}

/* TODO: group support */
/* TODO: group support

.job-log-group {

Expand All @@ -683,5 +683,5 @@ export function ansiLogToHTML(line) {
}
.job-log-list {

}
} */
</style>