Fix ref type error #24941
Merged
Fix ref type error #24941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
GiteaBot
added
the
lgtm/need 2
sillyguodong
approved these changes
May 26, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
May 26, 2023
routers/api/actions/runner/utils.go
Outdated
| @@ -141,6 +141,9 @@ func generateTaskContext(t *actions_model.ActionTask) *structpb.Struct { | |||
| // additional contexts | |||
| "gitea_default_actions_url": setting.Actions.DefaultActionsURL, | |||
| }) | |||
| if err != nil { | |||
| log.Error("%v", err) | |||
There was a problem hiding this comment.
It need a clearer message
wxiaoguang
approved these changes
May 26, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 29, 2023
* upstream/main: Test query must have "order by" explicitly to avoid unstable results (go-gitea#24963) Help to recover from corrupted levelqueue (go-gitea#24912) [skip ci] Updated translations via Crowdin Remove meta tags `theme-color` and `default-theme` (go-gitea#24960) Add dark mode to API Docs (go-gitea#24971) Update JS dependencies (go-gitea#24969) Replace Fomantic reset module with our own (go-gitea#24948) simple docs fixes: 'pull request' page (en-us & zh-tw) link path to 'issue-pull-request-templates' (go-gitea#24961) Remove reference to caddy v1 in docs (go-gitea#24962) Improve and fix bugs surrounding reactions (go-gitea#24760) Use `[git.config]` for reflog cleaning up (go-gitea#24958) Improve logger Pause handling (go-gitea#24946) Do not output "Trace" level logs from process manager by default (go-gitea#24952) Make the 500 page load themes (go-gitea#24953) [skip ci] Updated translations via Crowdin docs: remove an extraneous whitespace (go-gitea#24949) Show `bot` label next to username when rendering autor link if the user is a bot (go-gitea#24943) Improve some Forms (go-gitea#24878) Improve queue and logger context (go-gitea#24924) Fix ref type error (go-gitea#24941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the wrong type of reframe in the action task context map
Caused by #24634