Add WithPullRequest for actionsNotifier
#25144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
added
outdated/backport/v1.19
lunny
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wolfogre
approved these changes
Jun 9, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 11, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 11, 2023
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Jun 11, 2023
Backport #25144 by @Zettat123 Fix #25093 If [`WithPullRequest`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L90-L96) is not called, the `Ref` in [`notifyInput`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L55-L65) will be empty, so the workflows in the head branch will not be found and triggered. Co-authored-by: Zettat123 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 12, 2023
* upstream/main: [skip ci] Updated licenses and gitignores Add `WithPullRequest` for `actionsNotifier` (go-gitea#25144) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Update github.com/google/go-github to v53 (go-gitea#25157) Fix bug for code search if code is disabled (go-gitea#25173) Minor arc-green color tweaks (go-gitea#25175) Fix duplicate Reviewed-by trailers (go-gitea#24796) Fix go-gitea#25133 (go-gitea#25162) Fix mobile navbar and misc cleanups (go-gitea#25134) Button and color enhancements (go-gitea#24989) Fix setup-go actions (go-gitea#25167) # Conflicts: # templates/base/head_navbar.tmpl
lunny
pushed a commit
that referenced
this pull request
Jun 12, 2023
Backport #25144 by @Zettat123 Fix #25093 If [`WithPullRequest`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L90-L96) is not called, the `Ref` in [`notifyInput`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L55-L65) will be empty, so the workflows in the head branch will not be found and triggered.
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jun 23, 2023
…a#25196) Backport go-gitea#25144 by @Zettat123 Fix go-gitea#25093 If [`WithPullRequest`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L90-L96) is not called, the `Ref` in [`notifyInput`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L55-L65) will be empty, so the workflows in the head branch will not be found and triggered. Co-authored-by: Zettat123 <[email protected]> (cherry picked from commit de6ac4b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25093
If
WithPullRequestis not called, theRefinnotifyInputwill be empty, so the workflows in the head branch will not be found and triggered.