Skip to content

Manuall backport of locale for 1.20 #25635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Manuall backport of locale for 1.20 #25635

merged 1 commit into from
Jul 3, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 3, 2023 •
edited
Loading

Manually checked most

@GiteaBot GiteaBot added this to the 1.20.0 milestone Jul 3, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 3, 2023
@go-gitea go-gitea deleted a comment from GiteaBot Jul 3, 2023
@wxiaoguang wxiaoguang changed the title WIP: backport locale for 1.20 Backport locale for 1.20 Jul 3, 2023
@wxiaoguang wxiaoguang mentioned this pull request Jul 3, 2023
Closed
@silverwind
Copy link
Member

Where do all the empty line deletions come from and can we avoid them in the future?

@wxiaoguang
Copy link
Contributor Author

Where do all the empty line deletions come from and can we avoid them in the future?

After our INI package refactoring.

@wxiaoguang
Copy link
Contributor Author

Where do all the empty line deletions

This problem is more complicated. Besides the empty line deletions, there are also other changes like `foo` to foo, or quote changes.

The non-en_US locales are generated by Crowdin in main branches. But when Gitea's ini package writes it, the ini package has its own quirks.

@silverwind
Copy link
Member

Sounds like we may want to migrate locales to a more sane format, like JSON or YAML.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 3, 2023
@wxiaoguang
Copy link
Contributor Author

It's not related to INI itself, but the problem is caused by the legacy ini package which Gitea is using.

@denyskon denyskon self-requested a review July 3, 2023 14:02
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 3, 2023
@6543 6543 merged commit e5b684e into go-gitea:release/v1.20 Jul 3, 2023
@6543 6543 changed the title Backport locale for 1.20 Manuall backport of locale for 1.20 Jul 3, 2023
@6543 6543 added modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 3, 2023
@wxiaoguang wxiaoguang deleted the backport-locale branch July 3, 2023 14:17
@yardenshoham yardenshoham mentioned this pull request Jul 3, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @denyskon @GiteaBot @6543