Skip to content

Add elapsed time on debug for slow git commands #25642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Add elapsed time on debug for slow git commands #25642

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79a7b15
Add escaped time on debug for slow git commands
lunny Jul 3, 2023
81ceb9d
Update modules/git/command.go
lunny Jul 3, 2023
49dce85
Update modules/git/command.go
lunny Jul 3, 2023
3ee4049
Make the time elapse more accurate
lunny Jul 4, 2023
f49b136
Merge branch 'main' into lunny/add_slow_git_log
lunny Jul 4, 2023
624db01
Merge branch 'lunny/add_slow_git_log' of github.com:lunny/gitea into …
lunny Jul 4, 2023
8b1a9c3
Merge branch 'main' into lunny/add_slow_git_log
GiteaBot Jul 4, 2023
566b4cf
Merge branch 'main' into lunny/add_slow_git_log
GiteaBot Jul 4, 2023
1ad4c20
Merge branch 'main' into lunny/add_slow_git_log
GiteaBot Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion modules/git/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ func (c *Command) Run(opts *RunOpts) error {
}
defer finished()

startTime := time.Now()

cmd := exec.CommandContext(ctx, c.prog, c.args...)
if opts.Env == nil {
cmd.Env = os.Environ()
Expand All @@ -327,7 +329,13 @@ func (c *Command) Run(opts *RunOpts) error {
}
}

if err := cmd.Wait(); err != nil && ctx.Err() != context.DeadlineExceeded {
err := cmd.Wait()
elapsed := time.Since(startTime)
if elapsed > time.Second {
log.Debug("slow git.Command.Run: %s (%s)", c, elapsed)
}

if err != nil && ctx.Err() != context.DeadlineExceeded {
return err
}

Expand Down