Import sortablejs only once#25936
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/enhancement
delvh
approved these changes
Jul 17, 2023
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jul 17, 2023
GiteaBot
added
lgtm/done
6543
added
the
reviewed/wait-merge
jolheiser
approved these changes
Jul 17, 2023
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 18, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Import `sortablejs` only once (go-gitea#25936) Make environment-to-ini work with INSTALL_LOCK=true (go-gitea#25926) Ignore `runs-on` with expressions when warning no matched runners (go-gitea#25917) Skip unuseful error message in dev mode when watching local filesystem (go-gitea#25919) Add shutting down notice (go-gitea#25920) Downgrading Snap to build with node/18 instead of node/20 Fix margin on the new/edit project page. (go-gitea#25885) Add 1.20.0 changelog (go-gitea#25901) Fix incorrect milestone count when provide a keyword (go-gitea#25880) Avoid opening/closing PRs which are already merged (go-gitea#25883) Make `add line comment` buttons focusable (go-gitea#25894) Fix "Flash" message usage (go-gitea#25895) [skip ci] Updated translations via Crowdin Add support for different Maven POM encoding (go-gitea#25873)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
sortablejswas imported twice, once synchronously and once asynchronously, leading to webpack creating duplicate output code (once in the index bundle, and once in a separate chunk). Fix this by always asynchronously importing it. This was one of the build warnings observed when trying to build with vite.