Fix some typos #26031

harryzcy · 2023-07-21T05:16:44Z

As title

wxiaoguang · 2023-07-21T05:30:48Z

be overridden ?

wolfogre · 2023-07-21T06:27:11Z

Now I'm sure it was fixed by some spell check tools, PrecendingCharacter is function defined in external packages.

I'm not a fan of doing this for a big repo all at once. It comes with more risks than benefits.

harryzcy · 2023-07-21T06:32:55Z

Ok, sure. It's checked by spell checker and replaced manually in the editor.

delvh · 2023-07-21T08:16:15Z

contrib/backport/README

@@ -11,7 +11,7 @@ The default version will read from `docs/config.yml`. You can override this
 using the option `--version`.

 The upstream branches will be fetched, using the remote `origin`. This can
-be overrided using `--upstream`, and fetching can be avoided using
+be overrode using `--upstream`, and fetching can be avoided using


Suggested change

be overrode using `--upstream`, and fetching can be avoided using

be overridden using `--upstream`, and fetching can be avoided using

delvh · 2023-07-21T08:16:29Z

docs/content/doc/administration/config-cheat-sheet.en-us.md

@@ -1305,7 +1305,7 @@ Defaultly every storage has their default base path like below
 | actions_log       | actions_log/       |
 | actions_artifacts | actions_artifacts/ |

-And bucket, basepath or `SERVE_DIRECT` could be special or overrided, if you want to use a different you can:
+And bucket, basepath or `SERVE_DIRECT` could be special or overriden, if you want to use a different you can:


Suggested change

And bucket, basepath or `SERVE_DIRECT` could be special or overriden, if you want to use a different you can:

And bucket, basepath or `SERVE_DIRECT` could be special or overridden, if you want to use a different you can:

delvh · 2023-07-21T08:19:09Z

modules/packages/rpm/metadata.go

-	PropertyMetadata = "rpm.metdata"
+	PropertyMetadata = "rpm.metadata"


Is that change really possible?
I'm not sure if it isn't breaking.

delvh · 2023-07-21T08:20:40Z

templates/swagger/v1_json.tmpl

@@ -22008,7 +22008,7 @@
        "author": {
          "$ref": "#/definitions/CommitUser"
        },
-        "commiter": {
+        "committer": {


Not good.
That means we have a breaking change in this PR.

delvh · 2023-07-21T08:21:03Z

services/pull/merge_merge.go

@@ -9,7 +9,7 @@ import (
 	"code.gitea.io/gitea/modules/log"
 )

-// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to tbe staging branch (equal to the pr.BaseBranch)
+// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to the staging branch (equal to the pr.BaseBranch)


Suggested change

// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to the staging branch (equal to the pr.BaseBranch)

// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to be the staging branch (equal to the pr.BaseBranch)

delvh

Meant to request changes, the API change must be reverted.

puni9869 · 2023-07-21T10:03:35Z

Q. Don't we have spell checker in github action which checks all typos?

silverwind · 2023-07-21T11:52:18Z

There is misspell-check running during checks-backend, but it doesn't catch much. Something better would be appreciated.

gitea/Makefile

Lines 311 to 313 in 2f0e79e

    
           .PHONY: misspell-check 
        
           misspell-check: 
        
           	go run $(MISSPELL_PACKAGE) -error $(GO_DIRS) $(WEB_DIRS)

silverwind · 2023-07-21T11:56:09Z

I think it's worth a try to add https://github.com/facelessuser/pyspelling via poetry and run that in addition to misspell.

puni9869 · 2023-07-21T11:56:51Z

I think it's worth a try to add https://github.com/facelessuser/pyspelling via poetry and run that in addition to misspell.

May be we can consider https://github.com/super-linter/super-linter, but its a lil bit heavy, a monolith, we can customize it specfic to our use case.

puni9869 · 2023-07-21T11:58:55Z

I think it's worth a try to add https://github.com/facelessuser/pyspelling via poetry and run that in addition to misspell.

I can give a try in next PR

silverwind · 2023-07-21T12:03:21Z

May be we can consider https://github.com/super-linter/super-linter, but its a lil bit heavy, a monolith, we can customize it specfic to our use case.

No, because every task needs to be runnable locally and once you add something specific to GH Actions, you lose the ability to run checks locally which is very important.

super-linter is for lazy projects. We are not lazy 😉.

puni9869 · 2023-07-21T12:04:16Z

May be we can consider https://github.com/super-linter/super-linter, but its a lil bit heavy, a monolith, we can customize it specfic to our use case.

No, because every task needs to be runnable locally and once you add something specific to GH Actions, you lose the ability to run checks locally which is very important.

Yup, thats true. Let's stick to your suggested package then. No worries

yardenshoham · 2023-07-21T13:59:20Z

I like https://github.com/streetsidesoftware/cspell-cli https://github.com/streetsidesoftware/cspell-action https://github.com/streetsidesoftware/vscode-spell-checker

silverwind · 2023-07-21T14:14:59Z

Ideally it should be something we can install and lock down via npm, poetry, golang or even cargo. pyspelling is not ideal because it does not ship aspell so we can not lock it down to a version.

yardenshoham · 2023-07-21T14:16:34Z

It's on npm

silverwind · 2023-07-21T14:20:25Z

Ah yes, I was just about to post cspell as well.

harryzcy · 2023-07-21T15:25:23Z

I was using typos.

silverwind · 2023-07-21T16:10:20Z

I wonder how those two compare. Using rust crate for a tool should be in the realm of possibilites at least, even thought I have not done that so far 😉.

harryzcy added 4 commits July 21, 2023 00:01

Fix some typos

6f6682a

A few more

c8c0508

More fixes in models and modules

d01952f

More in routers

34c30bc

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2023

pull-request-size bot added the size/L label Jul 21, 2023

harryzcy added 2 commits July 21, 2023 00:19

Revert some incorrect fixes

325b629

Merge branch 'main' into fix-typos

7d917a3

harryzcy added 3 commits July 21, 2023 00:31

be overridden

b732ec8

Fix

d8a8640

Fix

830cf90

delvh reviewed Jul 21, 2023

View reviewed changes

delvh requested changes Jul 21, 2023

View reviewed changes

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2023

wolfogre mentioned this pull request Jul 31, 2023

codespell: add config and action to codespell the code to avoid known typos #26194

Closed

harryzcy closed this Sep 15, 2023

puni9869 reopened this Sep 16, 2023

puni9869 closed this Sep 16, 2023

github-actions bot added type/docs This PR mainly updates/creates documentation modifies/api This PR adds API routes or modifies them topic/packages labels Sep 16, 2023

go-gitea locked as resolved and limited conversation to collaborators Dec 15, 2023

harryzcy deleted the fix-typos branch January 14, 2024 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some typos #26031

Fix some typos #26031

harryzcy commented Jul 21, 2023

wxiaoguang commented Jul 21, 2023

wolfogre commented Jul 21, 2023

harryzcy commented Jul 21, 2023

delvh Jul 21, 2023

delvh Jul 21, 2023

delvh Jul 21, 2023

delvh Jul 21, 2023

delvh Jul 21, 2023

delvh left a comment

puni9869 commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023

puni9869 commented Jul 21, 2023 •

edited

Loading

puni9869 commented Jul 21, 2023

silverwind commented Jul 21, 2023 •

edited

Loading

puni9869 commented Jul 21, 2023 •

edited

Loading

yardenshoham commented Jul 21, 2023

silverwind commented Jul 21, 2023 •

edited

Loading

yardenshoham commented Jul 21, 2023

silverwind commented Jul 21, 2023

harryzcy commented Jul 21, 2023

silverwind commented Jul 21, 2023 •

edited

Loading

	be overrode using `--upstream`, and fetching can be avoided using
	be overridden using `--upstream`, and fetching can be avoided using

	And bucket, basepath or `SERVE_DIRECT` could be special or overriden, if you want to use a different you can:
	And bucket, basepath or `SERVE_DIRECT` could be special or overridden, if you want to use a different you can:

		PropertyMetadata = "rpm.metdata"
		PropertyMetadata = "rpm.metadata"

	// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to the staging branch (equal to the pr.BaseBranch)
	// doMergeStyleMerge merges the tracking into the current HEAD - which is assumed to be the staging branch (equal to the pr.BaseBranch)

Fix some typos #26031

Fix some typos #26031

Conversation

harryzcy commented Jul 21, 2023

wxiaoguang commented Jul 21, 2023

wolfogre commented Jul 21, 2023

harryzcy commented Jul 21, 2023

delvh Jul 21, 2023

Choose a reason for hiding this comment

delvh Jul 21, 2023

Choose a reason for hiding this comment

delvh Jul 21, 2023

Choose a reason for hiding this comment

delvh Jul 21, 2023

Choose a reason for hiding this comment

delvh Jul 21, 2023

Choose a reason for hiding this comment

delvh left a comment

Choose a reason for hiding this comment

puni9869 commented Jul 21, 2023 • edited Loading

silverwind commented Jul 21, 2023 • edited Loading

silverwind commented Jul 21, 2023

puni9869 commented Jul 21, 2023 • edited Loading

puni9869 commented Jul 21, 2023

silverwind commented Jul 21, 2023 • edited Loading

puni9869 commented Jul 21, 2023 • edited Loading

yardenshoham commented Jul 21, 2023

silverwind commented Jul 21, 2023 • edited Loading

yardenshoham commented Jul 21, 2023

silverwind commented Jul 21, 2023

harryzcy commented Jul 21, 2023

silverwind commented Jul 21, 2023 • edited Loading

puni9869 commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023 •

edited

Loading

puni9869 commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023 •

edited

Loading

puni9869 commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023 •

edited

Loading

silverwind commented Jul 21, 2023 •

edited

Loading