Skip to content

Mention devtest in frontend contributing guidelines #26249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Mention devtest in frontend contributing guidelines #26249

merged 1 commit into from
Jul 31, 2023

Conversation

denyskon
Copy link
Member

Our devtest page contains some good UI examples which should be taken as example when working on Gitea UI. Mention it in our frontend contributing guidelines to for new contributors to know about it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 31, 2023
@denyskon denyskon mentioned this pull request Jul 31, 2023
Merged
@denyskon denyskon added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 31, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 31, 2023
@puni9869
Copy link
Member

YO, thats made my day great.
thanks @denyskon 🙇

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 31, 2023
@puni9869
Copy link
Member

🚀

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 31, 2023
@KN4CK3R KN4CK3R merged commit fc6c3d6 into go-gitea:main Jul 31, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 31, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 31, 2023
@denyskon denyskon deleted the patch-2 branch July 31, 2023 11:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 1, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
60900e0 
* upstream/main:
  Introduce `flex-list` & `flex-item` elements for Gitea UI (go-gitea#25790)
  Mention `devtest` in frontend contributing guidelines (go-gitea#26249)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@denyskon @puni9869 @silverwind @lunny @KN4CK3R @GiteaBot