Fix protected branch icon location#26576
Merged
techknowlogick merged 3 commits intoSep 27, 2023
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Aug 18, 2023
| @@ -1,4 +1,5 @@ | |||
| <!-- make sure this matches the color logic in web_src/js/components/DashboardRepoList.vue --> | |||
| <span class="gt-df gt-ac"> | |||
Contributor
There was a problem hiding this comment.
It's not right to put gt-df gt-ac everywhere. Only the parent container needs the "align-items: center"
Member
There was a problem hiding this comment.
Yes, also this gt-df gt-ac is essentially a noop because it wraps the child exactly so display: flex will not alter the rendering over default display: block.
wxiaoguang
reviewed
Aug 18, 2023
| {{end}} | ||
| <div class="gt-df gt-ac"> | ||
| {{if .DefaultBranchBranch.IsProtected}} | ||
| <span class="flex-text-inline gt-pr-2">{{svg "octicon-shield-lock"}}</span> |
Contributor
There was a problem hiding this comment.
The parent already has "align-items: center", this flex-text-inline is a no op for a single SVG element.
yp05327
force-pushed
the
fix-protected-branch-icon-in-branch-list
branch
from
6b05144 to
e2a7adb
Compare
delvh
approved these changes
Sep 27, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Sep 27, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
lgtm/need 1
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 27, 2023
GiteaBot
removed
the
reviewed/wait-merge
jolheiser
pushed a commit
that referenced
this pull request
Sep 27, 2023
Backport #26576 by @yp05327 Before:  After:  Co-authored-by: yp05327 <576951401@qq.com>
Contributor
|
Many |
Contributor
|
-> Improve branch list UI #27319 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 28, 2023
* giteaoffical/main: (22 commits) Fix review UI (go-gitea#27322) Improve issue history dialog and make poster can delete their own history (go-gitea#27323) Improve branch list UI (go-gitea#27319) doctor: delete action entries without existing user (go-gitea#27292) fix orphan check for deleted branch (go-gitea#27310) make writing main test easier (go-gitea#27270) [skip ci] Updated translations via Crowdin Fix protected branch icon location (go-gitea#26576) move the `gitea admin` subcommands into separate files (go-gitea#27307) Fix chinese translation (go-gitea#27296) bump bleve (go-gitea#27300) Redefine the meaning of column is_active to make Actions Registration Token generation easier (go-gitea#27143) Use vitest globals (go-gitea#27102) Fix divider in subscription page (go-gitea#27298) Fix yaml test (go-gitea#27297) Enable production source maps for index.js, fix CSS sourcemaps (go-gitea#27291) Fix some animation bugs (go-gitea#27287) Add missed return to actions view fetch (go-gitea#27289) Fix more yaml lint errors (go-gitea#27284) Fix incorrect change from go-gitea#27231 (go-gitea#27275) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: