add filter by author/assignee in /issues #25979 #26661

iminfinity · 2023-08-22T10:23:51Z

Resolves #25979

PR sponsored by Obmondo.com

templates/user/dashboard/issues.tmpl

lunny · 2023-08-23T01:09:11Z

~~Please wait #26657~~

CaiCandong · 2023-08-23T01:50:03Z

Before.mp4

~~I pulled it down and tested it, and as if this PR wasn't already done?~~

~~The contents of the dropdown box are also empty~~

I apologize for pulling the wrong branch.

iminfinity · 2023-08-23T19:29:34Z

@CaiCandong this is the intended behavior
Screencast from 24-08-23 12:57:49 AM IST.webm

routers/web/repo/issue.go

models/repo/user_repo.go

web_src/js/features/repo-issue-list.js

iminfinity · 2023-11-07T17:06:26Z

@6543 can you take a look at this as well

sebthom · 2024-01-26T18:02:44Z

@lunny Since #26657 has been resolved by now. Is there anything else preventing this PR from being progressed or resolved? We would also love to see this being integrated into Gitea.

KlavsKlavsen · 2024-03-19T15:06:26Z

Whats the status here? if we update branch for conflicts - will you merge? its a very simple improvement :(
Also - we plan to add label and milestone filters to this page too (we need them) - and jira-like drag'n'drop planning.. But we need a way to get our PRs merged :( @lunny WDYT ?
the planning would just be a 'checkbox' - that would show 4 weeks ahead segments - simply looking at due date - and show a box on left side for each of the 'next 4 weeks' - making it super simple to find your issue and drag it to the left onto the week you want it to be 'done' and UI will set the due date for the issue to end of that week - and updating will then show the issue in the week it was set for.. (and then properly add selector for issues per page - so we can show entire 4 weeks of plans if we want it on one page or something).

This would help us use gitea for proper planning.. simply select a milestone (btw. we have added global milestones (will push PR very soon) - helps us group issues across repos based on features we work on) - and then we can just drag'n'drop to a week - and use our team labels - to easily see the plan for coming 4 weeks per team - and to fill those 4 weeks from our milestones.

We were discussing putting 'planning' in a diff. page than issues - but its actually very few addons needed for it to work properly - so seemed very much like duplication..
Unless we write it so it uses the API to fetch tickets - ie. less static.. speakup if you prefer we do it that way.. we really want our improvements merged - so they benefit all.. we are afterall a company that prefers to ONLY do open source development - and its sad to see it never getting merged 😢

lunny · 2024-03-19T15:54:41Z

Whats the status here? if we update branch for conflicts - will you merge? its a very simple improvement :( Also - we plan to add label and milestone filters to this page too (we need them) - and jira-like drag'n'drop planning.. But we need a way to get our PRs merged :( @lunny WDYT ? the planning would just be a 'checkbox' - that would show 4 weeks ahead segments - simply looking at due date - and show a box on left side for each of the 'next 4 weeks' - making it super simple to find your issue and drag it to the left onto the week you want it to be 'done' and UI will set the due date for the issue to end of that week - and updating will then show the issue in the week it was set for.. (and then properly add selector for issues per page - so we can show entire 4 weeks of plans if we want it on one page or something).

This would help us use gitea for proper planning.. simply select a milestone (btw. we have added global milestones (will push PR very soon) - helps us group issues across repos based on features we work on) - and then we can just drag'n'drop to a week - and use our team labels - to easily see the plan for coming 4 weeks per team - and to fill those 4 weeks from our milestones.

We were discussing putting 'planning' in a diff. page than issues - but its actually very few addons needed for it to work properly - so seemed very much like duplication.. Unless we write it so it uses the API to fetch tickets - ie. less static.. speakup if you prefer we do it that way.. we really want our improvements merged - so they benefit all.. we are afterall a company that prefers to ONLY do open source development - and its sad to see it never getting merged 😢

Thank you for your patience, sorry there are too many issues/PRs that need to be handled. I think we can pick up this again.

6543 · 2024-03-19T18:57:41Z

having a milestone assigned do at least shine a light when a featurefreeze happens ... so I'll assign it now

6543 · 2024-03-19T19:02:33Z

about add filters etc ... to the global issue/pull dashboard, if not done right it gets more and more overloaded.

the a related current discussion happend at #29701 (comment) for example ...

KlavsKlavsen · 2024-03-20T04:29:13Z

@6543 You are absolutely correct.. also the issue pages for repo vs. global are different - thats also very odd (and causes confusion).
Primarily though its a huge problem, that you cannot filter issues on labels, milestones either - as that removes their usefulness (You can filter on labels if you can find an issue with the label and click on that.. LOL).

We have a couple of dedicated UX'es who, work on these problems every day - overload vs. functionality etc. - I'd gladly ask to give an opinion if you want.
IMHO you need to first agree what features is needed - and then get someone with knowledge about people and such (UX) to design the page for how to implement the features, so they do not cause such overloads, but become natural.

I hope we do not disagree about the clear need for the ability to filter as such. Jira f.ex. has this - and its still a very popular product - so clearly that should not be in discussion :)

lunny · 2024-04-11T12:08:09Z

routers/web/user/home.go

@@ -764,19 +784,6 @@ func UsernameSubRoute(ctx *context.Context) {
 func getUserIssueStats(ctx *context.Context, ctxUser *user_model.User, filterMode int, opts *issue_indexer.SearchOptions) (*issues_model.IssueStats, error) {
 	doerID := ctx.Doer.ID

-	opts = opts.Copy(func(o *issue_indexer.SearchOptions) {


Why remove these code?

lunny · 2024-04-20T03:14:04Z

models/issues/issue_stats.go

@@ -33,6 +33,7 @@ const (
 	FilterModeMention
 	FilterModeReviewRequested
 	FilterModeReviewed
+	FilterModeSearch


I don't think it should be a filter mode since this filter can combind with other filters. It's just standalone filters.

we need some way to tell getUserIssueStats func that poster/assignee filter is applied, otherwise it will put doerID in everything and the count(open/closed/total) will be incorrect

even if we pass opts with correct data, it wont apply without the filtermode
https://github.com/go-gitea/gitea/blob/main/routers/web/user/home.go#L792-L806

wxiaoguang · 2024-12-08T06:47:17Z

After playing with the issue list for a while, I think I could fully understand the problem now.

I have posted my initial work here: Refactor issue list #32755

In short: it is impossible to add the filter by this approach. The root problem is that m.Get("/posters", repo.IssuePosters) won't work correctly, it shouldn't list all users from database as poster candidates.

wxiaoguang · 2024-12-09T15:52:18Z

I will add the initial support after Refactor issue filter (labels, poster, assignee) #32771

wxiaoguang · 2024-12-10T11:34:56Z

Let's do this: Add label/author/assignee filters to the user/org home issue list #32779

…2779) Replace #26661, fix #25979 Not perfect, but usable and much better than before. Since it is quite complex, I am not quite sure whether there would be any regression, if any, I will fix in first time. I have tested the related pages many times: issue list, milestone issue list, project view, user issue list, org issue list.

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 22, 2023

pull-request-size bot added the size/L label Aug 22, 2023

iminfinity mentioned this pull request Aug 22, 2023

add filter by author/assignee in /issues (#25979) #26643

Closed

silverwind reviewed Aug 22, 2023

View reviewed changes

templates/user/dashboard/issues.tmpl Outdated Show resolved Hide resolved

iminfinity force-pushed the add/filter branch from 1866bb5 to 967374d Compare August 23, 2023 19:24

KlavsKlavsen mentioned this pull request Aug 24, 2023

[Proposal] Add third issue state "Resolved" #14893

Open

lunny reviewed Aug 24, 2023

View reviewed changes

routers/web/repo/issue.go Outdated Show resolved Hide resolved

KlavsKlavsen mentioned this pull request Aug 24, 2023

Global kanban with filters #26456

Open

iminfinity force-pushed the add/filter branch 2 times, most recently from 84a82f5 to 9b59133 Compare August 31, 2023 19:16

techknowlogick added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Sep 14, 2023

techknowlogick reviewed Sep 14, 2023

View reviewed changes

models/repo/user_repo.go Outdated Show resolved Hide resolved

silverwind reviewed Sep 14, 2023

View reviewed changes

web_src/js/features/repo-issue-list.js Outdated Show resolved Hide resolved

iminfinity force-pushed the add/filter branch from 9b59133 to 15c444d Compare September 15, 2023 12:04

pull-request-size bot added size/M and removed size/L labels Sep 15, 2023

iminfinity force-pushed the add/filter branch from 15c444d to c599320 Compare September 15, 2023 12:08

pull-request-size bot added size/L and removed size/M labels Sep 15, 2023

iminfinity force-pushed the add/filter branch 2 times, most recently from aca34c5 to 6aad6ff Compare September 15, 2023 17:47

iminfinity force-pushed the add/filter branch from 6aad6ff to 1380c4b Compare October 19, 2023 18:14

github-actions bot added the modifies/frontend label Oct 19, 2023

add filter by author/assignee in /issues

cb6a227

iminfinity force-pushed the add/filter branch from 1380c4b to cb6a227 Compare October 19, 2023 18:16

iminfinity added 2 commits January 29, 2024 23:58

Merge branch 'main' into add/filter

8e52cc6

fix pagination

94a1caf

denyskon added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 16, 2024

6543 added this to the 1.23.0 milestone Mar 19, 2024

silverwind removed the modifies/frontend label Mar 31, 2024

lunny reviewed Apr 11, 2024

View reviewed changes

lunny reviewed Apr 20, 2024

View reviewed changes

lunny modified the milestones: 1.23.0, 1.24.0 Oct 9, 2024

wxiaoguang mentioned this pull request Dec 9, 2024

allow issue filtering in "global issue view" #25979

Closed

wxiaoguang closed this Dec 10, 2024

wxiaoguang mentioned this pull request Dec 10, 2024

Add label/author/assignee filters to the user/org home issue list #32779

Merged

GiteaBot removed this from the 1.24.0 milestone Dec 10, 2024

go-gitea locked as resolved and limited conversation to collaborators Mar 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add filter by author/assignee in /issues #25979 #26661

add filter by author/assignee in /issues #25979 #26661

iminfinity commented Aug 22, 2023

lunny commented Aug 23, 2023 •

edited

Loading

CaiCandong commented Aug 23, 2023 •

edited

Loading

iminfinity commented Aug 23, 2023

iminfinity commented Nov 7, 2023

sebthom commented Jan 26, 2024

KlavsKlavsen commented Mar 19, 2024 •

edited

Loading

lunny commented Mar 19, 2024

6543 commented Mar 19, 2024

6543 commented Mar 19, 2024

KlavsKlavsen commented Mar 20, 2024 •

edited

Loading

lunny Apr 11, 2024

lunny Apr 20, 2024

iminfinity Apr 25, 2024

iminfinity Apr 25, 2024

wxiaoguang commented Dec 8, 2024

wxiaoguang commented Dec 9, 2024

wxiaoguang commented Dec 10, 2024

add filter by author/assignee in /issues #25979 #26661

add filter by author/assignee in /issues #25979 #26661

Conversation

iminfinity commented Aug 22, 2023

lunny commented Aug 23, 2023 • edited Loading

CaiCandong commented Aug 23, 2023 • edited Loading

iminfinity commented Aug 23, 2023

iminfinity commented Nov 7, 2023

sebthom commented Jan 26, 2024

KlavsKlavsen commented Mar 19, 2024 • edited Loading

lunny commented Mar 19, 2024

6543 commented Mar 19, 2024

6543 commented Mar 19, 2024

KlavsKlavsen commented Mar 20, 2024 • edited Loading

lunny Apr 11, 2024

Choose a reason for hiding this comment

lunny Apr 20, 2024

Choose a reason for hiding this comment

iminfinity Apr 25, 2024

Choose a reason for hiding this comment

iminfinity Apr 25, 2024

Choose a reason for hiding this comment

wxiaoguang commented Dec 8, 2024

wxiaoguang commented Dec 9, 2024

wxiaoguang commented Dec 10, 2024

lunny commented Aug 23, 2023 •

edited

Loading

CaiCandong commented Aug 23, 2023 •

edited

Loading

KlavsKlavsen commented Mar 19, 2024 •

edited

Loading

KlavsKlavsen commented Mar 20, 2024 •

edited

Loading