Skip to content

Fix template bugs in recently_pushed_new_branches.tmpl#26744

Merged
wxiaoguang merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-branch-escape
Aug 27, 2023
Merged

Fix template bugs in recently_pushed_new_branches.tmpl#26744
wxiaoguang merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-branch-escape

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Aug 26, 2023 •
edited
Loading

Fix some bugs from #25715, fix #25830

  1. $.locale.Tr ... Safe needs Escape, but not PathEscapeSegments
  2. The attribute should be role
  3. The ComposeBranchCompareURL already does escaping correctly

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 26, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 26, 2023
@wxiaoguang wxiaoguang mentioned this pull request Aug 26, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2023
@puni9869
Copy link
Copy Markdown
Member

puni9869 commented Aug 26, 2023

🚀

@wxiaoguang wxiaoguang merged commit 5914a2f into go-gitea:main Aug 27, 2023
@wxiaoguang wxiaoguang deleted the fix-branch-escape branch August 27, 2023 00:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 27, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
130bf51 
* upstream/main:
  Move `modules/mirror` to `services` (go-gitea#26737)
  [skip ci] Updated translations via Crowdin
  Fix template bugs in recently_pushed_new_branches.tmpl (go-gitea#26744)
  Fix incorrect "tabindex" attributes (go-gitea#26733)
  Simplify helper CSS classes and avoid abuse (go-gitea#26728)
  Remove fomantic loader module (go-gitea#26670)
  Fix link in mirror docs (go-gitea#26719)
  Add `eslint-plugin-vue-scoped-css` (go-gitea#26720)
  Fixed text overflow in dropdown menu (go-gitea#26694)
  Make web context initialize correctly for different cases (go-gitea#26726)
  Remove incorrect CSS helper classes (go-gitea#26712)
  Focus editor on "Write" tab click (go-gitea#26714)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@puni9869 puni9869 puni9869 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

New pull request from last pushed branch 404 error

4 participants

@wxiaoguang @puni9869 @yardenshoham @GiteaBot