Refactor dashboard/feed.tmpl

[CaiCandong]

• Refactor ActionType to models/activities/action_type.go
• Replace the magic number in feed.tmlp with InAction

[silverwind]

Dashboard fails to load for me with 500 on my local instance after this:

Render failed, failed to render template: user/dashboard/dashboard, error: template error: builtin(static):user/dashboard/feeds:14:20 : executing "user/dashboard/feeds" at <.GetOpType.InActions>: can't evaluate field InActions in type activities.ActionType
----------------------------------------------------------------------
					{{if .GetOpType.InActions "create_repo"}}
					               ^

[CaiCandong]

Let me check It.
@silverwind
Is your source code consistent with main branch ? This function exists.

gitea/models/activities/action.go

Lines 129 to 136 in bafe133

	func (at ActionType) InActions(actions ...string) bool {
	for _, action := range actions {
	if action == at.String() {
	return true
	}
	}
	return false
	}

[silverwind]

Yes, I'm at bafe133.

[CaiCandong]

Yes, I'm at bafe133.

Thanks, indeed this function was missing.

gitea/templates/user/dashboard/feeds.tmpl

Lines 10 to 28 in e502be4

	{{if gt .ActUser.ID 0}}
	<a href="{{AppSubUrl}}/{{.GetActUserName | PathEscape}}" title="{{.GetDisplayNameTitle}}">{{.GetDisplayName}}</a>
	{{else}}
	{{.ShortActUserName}}
	{{end}}
	{{if eq .GetOpType 1}}
	{{$.locale.Tr "action.create_repo" (.GetRepoLink|Escape) (.ShortRepoPath|Escape) | Str2html}}
	{{else if eq .GetOpType 2}}
	{{$.locale.Tr "action.rename_repo" (.GetContent|Escape) (.GetRepoLink|Escape) (.ShortRepoPath|Escape) | Str2html}}
	{{else if eq .GetOpType 5}}
	{{if .Content}}
	{{$.locale.Tr "action.commit_repo" (.GetRepoLink|Escape) (.GetRefLink|Escape) (Escape .GetBranch) (.ShortRepoPath|Escape) | Str2html}}
	{{else}}
	{{$.locale.Tr "action.create_branch" (.GetRepoLink|Escape) (.GetRefLink|Escape) (Escape .GetBranch) (.ShortRepoPath|Escape) | Str2html}}
	{{end}}
	{{else if eq .GetOpType 6}}
	{{$index := index .GetIssueInfos 0}}
	{{$.locale.Tr "action.create_issue" ((printf "%s/issues/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
	{{else if eq .GetOpType 7}}

Your feeds.tmpl template doesn't seem to be aligned with action.go?
This PR was not released in 1.20.

[silverwind]

Must be something else. I defintely got 30cea70 on my main branch that exactly matches the remote.

[CaiCandong]

gitea/models/activities/action.go

Lines 129 to 136 in bafe133

	func (at ActionType) InActions(actions ...string) bool {
	for _, action := range actions {
	if action == at.String() {
	return true
	}
	}
	return false
	}

Does this code exist locally? It's kind of weird.

[silverwind]

Yes, it's there. Maybe I will dive deeper later, unless you find it first. You should be able to reproduce this hopefully. maybe it's something weird about my database (mysql).

[wxiaoguang]

It can't be related to database.

Have you re-compiled and restarted the Gitea instance? Or could you try to do it manually in case it's the air bug?

[silverwind]

I ran make clean-all build and that seems to have fixed it. Bad cache somewhere I assume.