Add .profile README to organization pages #27125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
Ready for review? |
I think so, I've completed the feature :) |
lunny
added
the
type/feature
puni9869
reviewed
Oct 2, 2023
|
|
||
| language := ctx.FormTrim("language") | ||
| ctx.Data["Language"] = language | ||
| func PrepareOrgProfileTabData(ctx *context.Context, profileGitRepo *git.Repository, profileReadme *git.Blob) { |
There was a problem hiding this comment.
Suggested change
| func PrepareOrgProfileTabData(ctx *context.Context, profileGitRepo *git.Repository, profileReadme *git.Blob) { | |
| func prepareOrgProfileTabData(ctx *context.Context, profileGitRepo *git.Repository, profileReadme *git.Blob) { |
puni9869
reviewed
Oct 2, 2023
| defer profileClose() | ||
| ctx.Data["HasProfileReadme"] = profileReadmeBlob != nil | ||
|
|
||
| PrepareOrgProfileTabData(ctx, profileGitRepo, profileReadmeBlob) |
There was a problem hiding this comment.
Suggested change
| PrepareOrgProfileTabData(ctx, profileGitRepo, profileReadmeBlob) | |
| prepareOrgProfileTabData(ctx, profileGitRepo, profileReadmeBlob) |
|
It looks like #27955 also implemented this and has been merged. Thank you for the PR! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, user profiles can have README markdown files displayed. Organizations can have this same thing on GitHub, so why not Gitea?
In adding this, I've also realised that since the user tab template is used by some organization pages, currently if a
.profilerepository and aREADME.mdfile exist on an organization, an Overview tab is shown on some pages even though it simply redirects to the repositories page:So this PR also makes these work as they should!
Screenshots
Before:
After:
I've also added the overview tab everywhere the organization tabs are visible (of course, only when the
.profilerepo and a README file exist, matching the behaviour for user profile pages)