tidy up archive modal #27131
Closed
tidy up archive modal #27131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it consistent with the other modals of the dangerous actions. Refs: https://codeberg.org/forgejo/forgejo/pulls/1432 (cherry picked from commit 8b1225f)
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Sep 19, 2023
| <div class="text right actions"> | ||
| <button class="ui cancel button">{{.locale.Tr "settings.cancel"}}</button> | ||
| <button class="ui red button">{{.locale.Tr "repo.settings.archive.button"}}</button> | ||
| </div> |
There was a problem hiding this comment.
Why is modal_actions_confirm.tmpl unsuitable?
delvh
reviewed
Sep 19, 2023
Comment on lines
+986
to
+989
| <form action="{{.Link}}" method="post"> | ||
| {{.CsrfTokenHtml}} | ||
| <input type="hidden" name="action" value="{{if .Repository.IsArchived}}unarchive{{else}}archive{{end}}"> | ||
| <input type="hidden" name="repo_id" value="{{.Repository.ID}}"> |
There was a problem hiding this comment.
What happened in these lines?
Whitespace seems to have changed, but I don't understand why.
There was a problem hiding this comment.
They would like to fix a "misalignment" bug, but the bug doesn't exist in Gitea anymore.
wxiaoguang
reviewed
Sep 19, 2023
| @@ -976,20 +976,23 @@ | |||
| {{end}} | |||
| </div> | |||
| <div class="content"> | |||
| <p> | |||
| <div class="ui warning message"> | |||
There was a problem hiding this comment.
It makes the UI looks unnecessarily complex by using such warning message.
I never see a dialog with inner warning color/border for the main content.
I think the old UI looks good enough, the content message is rendered as normal text:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://codeberg.org/forgejo/forgejo/pulls/1432
(cherry picked from commit 8b1225f)