Enhanced auth token / remember me#27606
Merged
Merged
Conversation
Add index.
KN4CK3R
added
type/feature
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Oct 13, 2023
GiteaBot
added
lgtm/need 1
delvh
added
the
pr/breaking
lunny
approved these changes
Oct 13, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 16, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Improve retrying index issues (go-gitea#27554) Replace more db.DefaultContext (go-gitea#27628) Fix 404 when there is an internal version of package (go-gitea#27615) [skip ci] Updated translations via Crowdin Add anchor to review types (go-gitea#26894) Update readme to remove drone svg (go-gitea#27624) Change the default branch in the agit docs (go-gitea#27621) Final round of `db.DefaultContext` refactor (go-gitea#27587) Fix permissions for Token DELETE endpoint to match GET and POST (go-gitea#27610) Enhanced auth token / remember me (go-gitea#27606) [skip ci] Updated translations via Crowdin rm outdated docs from some languages (go-gitea#27530) Upgrade go dependencies (go-gitea#27599) Fix build errors on BSD (in BSDMakefile) (go-gitea#27594) Enable shorthands in `declaration-strict-value` linter (go-gitea#27597) [skip ci] Updated translations via Crowdin Make disk clean action a bit more robust (go-gitea#27590)
brechtvl
added a commit
to blender/gitea
that referenced
this pull request
Nov 13, 2023
Without increasing database version. From upstream go-gitea#27606 The mechanism responsible for long-term authentication (the 'remember me' cookie) uses a weak construction technique. It will hash the user's hashed password and the rands value; it will then call the secure cookie code, which will encrypt the user's name with the computed hash. If one were able to dump the database, they could extract those two values to rebuild that cookie and impersonate a user. That vulnerability exists from the date the dump was obtained until a user changed their password. To fix this security issue, the cookie could be created and verified using a different technique such as the one explained at https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence#secure-remember-me-cookies. The PR removes the now obsolete setting `COOKIE_USERNAME`.
Member
|
@KN4CK3R why is this PR a feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27455
The now obsolete setting
[security].COOKIE_USERNAMEhas been removed.If you previously set it, you can now remove it from your config.