Fix sticky diff header background #27697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
puni9869
approved these changes
Oct 20, 2023
GiteaBot
added
lgtm/need 1
6543
approved these changes
Oct 20, 2023
GiteaBot
added
lgtm/done
6543
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 20, 2023
Fixes: go-gitea#27604 Add negative margins so the header covers any shadow of active elements. No rendering change of the content of the header because the padding counteracts the effect. <img width="128" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e">
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Oct 20, 2023
Backport #27697 by @silverwind Fixes: #27604 Add negative margins so the header covers any shadow of active elements. No rendering change of the content of the header because the padding counteracts the effect. <img width="128" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e"> Co-authored-by: silverwind <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 23, 2023
* upstream/main: Fix incorrect ctx usage in defer function (go-gitea#27740) Enable followCursor for language stats bar (go-gitea#27713) teams: new View button (go-gitea#27685) fix issues in translation file (go-gitea#27699) Fix an indentation in the Chinese documentation of Act Runner (go-gitea#27730) [skip ci] Updated translations via Crowdin Fix org team endpoint (go-gitea#27721) Improve diff tree spacing (go-gitea#27714) refactor: make db iterate context aware (go-gitea#27710) [FIX] resolve confusing colors in languages stats by insert a gap (go-gitea#27704) Fix sticky diff header background (go-gitea#27697) Replace -1 with GhostUserID (go-gitea#27703) Clean some functions about project issue (go-gitea#27705)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27604
Add negative margins so the header covers any shadow of active elements. No rendering change of the content of the header because the padding counteracts the effect.