Display issue task list on project cards#27865
Conversation
GiteaBot
added
the
lgtm/need 2
|
The icon/text spacing in that screenshot looks a bit odd, but not the fault of this PR of course. |
silverwind
left a comment
silverwind
left a comment
There was a problem hiding this comment.
Could maybe share a new subtemplate with issue list, otherwise LGTM.
GiteaBot
added
lgtm/need 1
denyskon
left a comment
denyskon
left a comment
There was a problem hiding this comment.
We should refactor this issue card to use "flex-text", but it is out of scope for this PR
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
| {{$tasks := .GetTasks}} | ||
| {{if gt $tasks 0}} | ||
| <div class="meta gt-my-2"> | ||
| {{svg "octicon-checklist" 16 "gt-mr-2 gt-vm"}} | ||
| <span class="gt-vm">{{.GetTasksDone}} / {{$tasks}}</span> | ||
| </div> | ||
| {{end}} |
There was a problem hiding this comment.
Can we perhaps extract a subtemplate instead of manually adding it each time?
There was a problem hiding this comment.
issue/PR list, milestones, projects, …
There was a problem hiding this comment.
They already share a template (besides projects now). I have little frontend knowledge, someone else must create a subtemplate which works in all places.
There was a problem hiding this comment.
When the HTML content is the same it's trivial to extract a subtemplate, e.g. cut-paste into new file and add {{template "file"}} in place.
There was a problem hiding this comment.
Sure, but the classes are totally different.
There was a problem hiding this comment.
Ideally make classes the same, but we can do later I guess then.
GiteaBot
removed
the
reviewed/wait-merge
* upstream/main: Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (go-gitea#27798) [skip ci] Updated translations via Crowdin Add `Hide/Show all checks` button to commit status check (go-gitea#26284) Fix http protocol auth (go-gitea#27875) Display issue task list on project cards (go-gitea#27865) Reduce margin/padding on flex-list items and divider (go-gitea#27872)
Display the issue task list on project cards.  Co-authored-by: Giteabot <teabot@gitea.io>
6 participants
Display the issue task list on project cards.