Filter inactive auth sources #27870
Merged
Filter inactive auth sources #27870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
type/bug
backport/v1.20
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Nov 1, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Nov 1, 2023
GiteaBot
added
lgtm/done
|
I was unable to create a backport for 1.20. @KN4CK3R, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
|
I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. 🍵 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 2, 2023
* giteaofficial/main: Filter inactive auth sources (go-gitea#27870) refactor postgres connection string building (go-gitea#27723) doc: actions/act-runner: document running as a systemd service (go-gitea#27844) Support storage base path as prefix (go-gitea#27827)
|
This will hide the unactive provider's linked accounts and users cannot unlink them from the UI. I have sent #27798 which could resolve the problem entirely. |
lunny
removed
backport/v1.20
KN4CK3R
added a commit
to KN4CK3R/gitea
that referenced
this pull request
Nov 5, 2023
Merged
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 6, 2023
* upstream/main: Fix edit topic UI (go-gitea#27925) Unify two factor check (go-gitea#27915) Revert go-gitea#27870 (go-gitea#27917) Fix JS NPE when viewing specific range of PR commits (go-gitea#27912) Install poetry dependencies with --no-root (go-gitea#27919) Show correct commit sha when viewing single commit diff (go-gitea#27916) Fix 500 when deleting a dismissed review (go-gitea#27903) Remove action runners on user deletion (go-gitea#27902) Remove SSH workaround (go-gitea#27893) Remove "tabindex" from some form buttons (go-gitea#27892) Refactor the function RemoveOrgUser (go-gitea#27582) Fix DownloadFunc when migrating releases (go-gitea#27887)
lng2020
removed
the
backport/manual
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Fix nil access for inactive auth sources. > Render failed, failed to render template: user/settings/security/security, error: template error: builtin(static):user/settings/security/accountlinks:32:20 : executing "user/settings/security/accountlinks" at <$providerData.IconHTML>: nil pointer evaluating oauth2.Provider.IconHTML Code tries to access the auth source of an `ExternalLoginUser` but the list contains only the active auth sources.
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Now that we have go-gitea#27798 we don't need the check from go-gitea#27870 anymore. With the check it's not possible to remove an inactive auth source from the user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nil access for inactive auth sources.
Code tries to access the auth source of an
ExternalLoginUserbut the list contains only the active auth sources.