Fix text overflow in branch/tag selector #28010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Nov 13, 2023
|
Welcome back descenders! (see letters g p q) |
silverwind
approved these changes
Nov 17, 2023
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Nov 17, 2023
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Nov 17, 2023
silverwind
reviewed
Nov 20, 2023
web_src/css/helpers.css
Outdated
| @@ -5,6 +5,7 @@ Gitea's private styles use `g-` prefix. | |||
| .gt-df { display: flex !important; } | |||
| .gt-dib { display: inline-block !important; } | |||
| .gt-ac { align-items: center !important; } | |||
| .gt-items-stretch { align-items: stretch !important; } | |||
There was a problem hiding this comment.
Looks good, but could you move it to line 62?
GiteaBot
added
lgtm/need 1
|
Before: We need to check this issue, before merge. Edited: |
lunny
added
the
issue/needs-feedback
|
bb1eedd fixed the issue above. |
yp05327
removed
the
issue/needs-feedback
denyskon
approved these changes
Jan 17, 2024
yardenshoham
added
the
giteabot/update-branch
|
@SohlRing please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
giteabot/update-branch
|
@SohlRing please fix the merge conflicts. 🍵 |
|
Seems we forgot this one. I'm not 100% sure if the helper changes still make sense, I will likely check it out with a fresh start. |
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 27, 2024
Fixes: go-gitea/gitea#27971 Fixes: go-gitea/gitea#28010 <img width="689" alt="Screenshot 2024-04-09 at 00 19 57" src="https://github.com/go-gitea/gitea/assets/115237/7c895a47-274f-40a6-a126-290658f1982d"> Also fixes a similar issue in issue list where CSS was there but not active because of missing `display: block`. <img width="372" alt="Screenshot 2024-04-09 at 00 18 25" src="https://github.com/go-gitea/gitea/assets/115237/cfbee7cd-2e15-4ac7-96ce-020816f48798"> --- Little conflict in branch_selector_field (repo.pulls.no_results is renamed in Gitea) And some weird conflict on new CSS rules added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27971
Before: Long branch/tag names overflow the selector button.
After: uses
text-overflow: ellipsis;to not do that.