Add global setting how timestamps should be rendered by yardenshoham · Pull Request #28657 · go-gitea/gitea

yardenshoham · 2023-12-30T11:21:54Z

Resolves viewing dates requires mouse hover #22493
Related to add preference setting for commit time display format #4520

Some admins prefer all timestamps to display the full date instead of relative time. They can do that now by setting

[ui]
PREFERRED_TIMESTAMP_TENSE = absolute

This setting is set to mixed by default, allowing dates to render as "5 hours ago". Here are some screenshots of the UI with this setting set to absolute:

Some admins prefer all timestamps to display the full date instead of relative time. They can do that now by setting ```ini [ui] PREFER_ABSOLUTE_TIMESTAMPS = true ``` Signed-off-by: Yarden Shoham <git@yardenshoham.com>

custom/conf/app.example.ini

delvh · 2023-12-30T11:45:44Z

custom/conf/app.example.ini

 ;EXPLORE_PAGING_DEFAULT_SORT = recentupdate
+;;
+;; Whether to prefer all timestamps to be rendered as absolute. Setting this to false means some timestamps would render as relative.
+;PREFER_ABSOLUTE_TIMESTAMPS = false


On a related note, wouldn't it be better to name the setting

Suggested change

;PREFER_ABSOLUTE_TIMESTAMPS = false

;TIMESTAMP_FORMAT = relative

with relative,absolute being the possible options (for now)

I don't think other options exist

I can think of a few at the top of my head: relative_v2, relative_legacy, absolute_v2, absolute_legacy, both, …

If relative is set here, some timestamps still render as absolute though (e.g. joined on date in profile page)

Yeah, but those are either intended or a bug.
Either way, to me it makes sense despite some minor exceptions.

Okay, if you add a comment why relative does not yet exist.

My current description is:

PREFERRED_TIMESTAMP_TENSE: mixed: The tense all timestamps should be rendered as. Possible values are absolute time (i.e. 1970-01-01, 11:59) or mixed which means some timestamps would render as relative (i.e. 2 days ago).

Today some of our timestamps are absolute and some are relative. I don't know why.

~~some~~ most

Done 0504a8c

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Yarden Shoham <git@yardenshoham.com>

JakobDev · 2023-12-30T14:45:09Z

Should we make this also a user setting?

yardenshoham · 2023-12-30T14:46:29Z

Tried it in #24342

delvh · 2023-12-30T14:46:56Z

See #24342, but yes, this is probably the next step.

wxiaoguang · 2023-12-30T15:29:05Z

Should we make this also a user setting?

The user setting system has some framework-level problems: too complex to use, and it might cause bugs easily.

I have refactored the system setting package in #27000 , IMO the user setting system also needs some big refactoring.

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

…estamps Signed-off-by: Yarden Shoham <git@yardenshoham.com>

custom/conf/app.example.ini

docs/content/administration/config-cheat-sheet.en-us.md

Co-authored-by: delvh <dev.lh@web.de>

* giteaofficial/main: Add global setting how timestamps should be rendered (go-gitea#28657) [skip ci] Updated translations via Crowdin Upgrade xorm to new version which supported update join for all supported databases (go-gitea#28590) Fix: system webhooks API bug (go-gitea#28531) Fix alpine package files are not rebuilt (go-gitea#28638) Fix migration test (go-gitea#28659) Avoid cycle-redirecting user/login page (go-gitea#28636) Fix long package version names overflowing (go-gitea#28619)

- Resolves go-gitea#22493 - Related to go-gitea#4520 Some admins prefer all timestamps to display the full date instead of relative time. They can do that now by setting ```ini [ui] PREFERRED_TIMESTAMP_TENSE = absolute ``` This setting is set to `mixed` by default, allowing dates to render as "5 hours ago". Here are some screenshots of the UI with this setting set to `absolute`: ![image](https://github.com/go-gitea/gitea/assets/20454870/f496457f-6afa-44be-a1e7-249ee5fe0706) ![image](https://github.com/go-gitea/gitea/assets/20454870/c03b14f5-063d-4e13-9780-76ab002d76a9) ![image](https://github.com/go-gitea/gitea/assets/20454870/f4b34e28-1546-4374-9199-c43348844edd) --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: delvh <dev.lh@web.de>

Add the option to prefer all timestamps to be absolute

ecfd154

Some admins prefer all timestamps to display the full date instead of relative time. They can do that now by setting ```ini [ui] PREFER_ABSOLUTE_TIMESTAMPS = true ``` Signed-off-by: Yarden Shoham <git@yardenshoham.com>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2023

pull-request-size bot added the size/M label Dec 30, 2023

github-actions bot added modifies/frontend modifies/docs labels Dec 30, 2023

yardenshoham added the type/enhancement An improvement of existing functionality label Dec 30, 2023

delvh reviewed Dec 30, 2023

View reviewed changes

delvh changed the title ~~Add the option to prefer all timestamps to be absolute~~ Add global setting how timestamps should be rendered Dec 30, 2023

yardenshoham and others added 2 commits December 30, 2023 12:28

Fix tests

b3d60f7

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

Clarify description

bbe69c3

Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Yarden Shoham <git@yardenshoham.com>

yardenshoham added 2 commits December 31, 2023 17:38

Switch to PreferredTimestampTense

0504a8c

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

Merge remote-tracking branch 'upstream/main' into prefer-absolute-tim…

5819397

…estamps Signed-off-by: Yarden Shoham <git@yardenshoham.com>

pull-request-size bot added size/L and removed size/M labels Dec 31, 2023

yardenshoham added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Dec 31, 2023

delvh approved these changes Jan 1, 2024

View reviewed changes

custom/conf/app.example.ini Outdated Show resolved Hide resolved

docs/content/administration/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 1, 2024

Apply suggestions from code review

b00611a

Co-authored-by: delvh <dev.lh@web.de>

wxiaoguang approved these changes Jan 1, 2024

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2024

delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 1, 2024

delvh added this to the 1.22.0 milestone Jan 1, 2024

Merge branch 'main' into prefer-absolute-timestamps

12b3b49

lunny merged commit cdc33b2 into go-gitea:main Jan 2, 2024

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 2, 2024

yardenshoham deleted the prefer-absolute-timestamps branch January 2, 2024 08:25

wxiaoguang mentioned this pull request Mar 2, 2024

Allow to select 24h time format #28371

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024

	;PREFER_ABSOLUTE_TIMESTAMPS = false
	;TIMESTAMP_FORMAT = relative

Uh oh!

Conversation

yardenshoham commented Dec 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delvh Dec 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobDev commented Dec 30, 2023

Uh oh!

yardenshoham commented Dec 30, 2023

Uh oh!

delvh commented Dec 30, 2023

Uh oh!

wxiaoguang commented Dec 30, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yardenshoham commented Dec 30, 2023 •

edited

Loading

delvh Dec 30, 2023 •

edited

Loading