Skip to content

Abstract for RepoPath #28966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Abstract for RepoPath #28966

wants to merge 9 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 28, 2024 •
edited
Loading

Follow #28940

  • Move all operations to rename repositories directory to gitrepo.RenameRepository
  • Move all operations to rename a user directory to gitrepo.RenameDir
  • Use gitrepo.IsRepositoryExist to do check whether a repository does exist on the repositories pool

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 28, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Jan 28, 2024
@lunny lunny mentioned this pull request Feb 3, 2024
Open
@github-actions github-actions bot added the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Feb 8, 2024
@lunny lunny marked this pull request as draft March 4, 2024 08:06
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 13, 2024
@lunny lunny mentioned this pull request Mar 13, 2025
Merged
lunny added a commit that referenced this pull request Mar 14, 2025
@lunny
Add abstraction layer to check if the repository exists on disk (#33874)
9c673d0 
Extract from #28966 

This PR uses `gitrepo.IsRepositoryExist` instead of `util.IsExist` to
detect whether the repository exist in disk. This will move `RepoPath`
detail behind of package `gitrepo` to make it easier to do possible
changes where storing the repositories.

No code change
@lunny lunny mentioned this pull request Mar 14, 2025
Merged
techknowlogick pushed a commit that referenced this pull request Mar 14, 2025
@lunny
Add abstraction layer to delete repository from disk (#33879)
55cc649 
Extract from #28966 
Follow #33874
This was referenced Mar 14, 2025
Merged
Merged
Merged
@lunny
Copy link
Member Author

lunny commented Mar 14, 2025

Closed as most of code are extracted to other PRs.

@lunny lunny closed this Mar 14, 2025
@lunny lunny deleted the lunny/remove_repo_path branch March 14, 2025 19:50
techknowlogick pushed a commit that referenced this pull request Mar 16, 2025
@lunny
Move hooks function to gitrepo and reduce expose repopath (#33890)
7fd44a8 
Extract from #28966 
Follow #33874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lunny @GiteaBot