Allow non-admin users to delete review requests#29057
Merged
lunny merged 31 commits intogo-gitea:mainfrom Feb 24, 2024
Merged
Conversation
Member
|
Could you create tests for the api calls which test the behaviour? |
lunny
approved these changes
Feb 17, 2024
wolfogre
approved these changes
Feb 20, 2024
Member
|
BTW, I think it's a design change (even somewhat breaking) instead of bug fixing. I'm not sure if it's a good idea to backport it. |
Member
Erm… |
Contributor
Author
In my view, a user who can read the PR is also likely to know who should/shouldn't review the PR. Also, I followed @lunny 's idea in #14459 (comment) where the |
Member
Read permission of issue or pr units can create issue or pr. |
Member
|
Ready for merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14459
The following users can add/remove review requests of a PR