Skip to content

Remove jQuery from the user search form in admin page#29151

Merged
KN4CK3R merged 4 commits into
go-gitea:mainfrom
yardenshoham:admin-users-jquery
Feb 13, 2024
Merged

Remove jQuery from the user search form in admin page#29151
KN4CK3R merged 4 commits into
go-gitea:mainfrom
yardenshoham:admin-users-jquery

Conversation

@yardenshoham
Copy link
Copy Markdown
Member

@yardenshoham yardenshoham commented Feb 12, 2024

  • Switched to plain JavaScript
  • Tested the form and it works as before

@yardenshoham
Remove jQuery from the user search form in admin page
eb1478c 
- Switched to plain JavaScript
- Tested the form and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 12, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 12, 2024
silverwind
silverwind approved these changes Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jquery removal is always welcome

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2024
wxiaoguang
wxiaoguang reviewed Feb 13, 2024
View reviewed changes
Comment thread web_src/js/features/admin/users.js Outdated
wxiaoguang
wxiaoguang reviewed Feb 13, 2024
View reviewed changes
Comment thread web_src/js/features/admin/users.js Outdated
wxiaoguang
wxiaoguang reviewed Feb 13, 2024
View reviewed changes
Comment thread web_src/js/features/admin/users.js Outdated
@yardenshoham
Fix review comments
aa95236 
- Don't `return false`
- Prevent default on reset button click
- Search in form instead of document

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham
Merge branch 'main' into admin-users-jquery
9e0677b
wxiaoguang
wxiaoguang reviewed Feb 13, 2024
View reviewed changes
Comment thread web_src/js/features/admin/users.js Outdated
wxiaoguang
wxiaoguang reviewed Feb 13, 2024
View reviewed changes
Comment thread web_src/js/features/admin/users.js Outdated
@yardenshoham @wxiaoguang
Apply suggestions from code review
dd9398d 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 13, 2024
@KN4CK3R KN4CK3R merged commit a8748ee into go-gitea:main Feb 13, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 13, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 13, 2024
@yardenshoham yardenshoham deleted the admin-users-jquery branch February 13, 2024 14:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
82aedae 
* giteaofficial/main: (38 commits)
  Document how the TOC election process works (go-gitea#29135)
  Runner tokens are multi use (go-gitea#29153)
  Fix Gitpod logic of setting ROOT_URL (go-gitea#29162)
  Remove jQuery from the user search form in admin page (go-gitea#29151)
  Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
  Show `View at this point in history` for every commit (go-gitea#29122)
  [skip ci] Updated translations via Crowdin
  Add merge style `fast-forward-only` (go-gitea#28954)
  Use Markdown alert syntax for notes in README (go-gitea#29150)
  Refactor issue template parsing and fix API endpoint (go-gitea#29069)
  [skip ci] Updated translations via Crowdin
  Update some translations and fix markdown formatting (go-gitea#29099)
  Show more settings for empty repositories (go-gitea#29130)
  Update JS and PY dependencies (go-gitea#29127)
  Add alert blocks in markdown (go-gitea#29121)
  Remove obsolete border-radius on comment content (go-gitea#29128)
  Make blockquote border size less aggressive (go-gitea#29124)
  Drop "@" from email sender to avoid spam filters (go-gitea#29109)
  [skip ci] Updated translations via Crowdin
  Disallow duplicate storage paths (go-gitea#26484)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 15, 2024
@yardenshoham @wxiaoguang @silverwind
Remove jQuery from the user search form in admin page (go-gitea#29151)
3341f2b 
- Switched to plain JavaScript
- Tested the form and it works as before

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@yardenshoham @wxiaoguang @silverwind
Remove jQuery from the user search form in admin page (go-gitea#29151)
a75edf0 
- Switched to plain JavaScript
- Tested the form and it works as before

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yardenshoham @silverwind @wxiaoguang @delvh @KN4CK3R @GiteaBot