Lazyloading diff-stats to improve PR loading time

[zokkis]

Lazyloading of diff-stats to improve loading time

before:
Screencast from 14.02.2024 03:15:15.webm

after:
Screencast from 14.02.2024 03:11:49.webm

[wxiaoguang]

At first glance, it seems to be tricky and hacky. If in the future there are more and more similar approaches, I guess the code would be more and more fragile? Just my personal opinion.

[zokkis]

At first glance, it seems to be tricky and hacky. If in the future there are more and more similar approaches, I guess the code would be more and more fragile? Just my personal opinion.

Is it the approche to send dependig on the htmx header, the switching Tabs with htmx in generell or just the lazyloading of the stats?

[wxiaoguang]

In my mind, the approach could be more straightforward: introduce a new endpoint, use fetch/ajax to load the data, and render the UI (maybe also refactor the Vue component at the same time). The htmx seems an over-engineering here.

[wxiaoguang]

This patch is too hacky.

I have refactored some "diff" related code, feel free to follow the new mechanism.