Integrate public as bindata optionally#293
Merged
Merged
Conversation
Contributor
|
I thought this was a huge PR, but then I saw all the LGTM |
Member
|
LGTM |
Contributor
|
Which package is pulling in BoltDB and EtcD? o.O |
Member
Author
|
I think boltdb is a missing dependency for tidb, etcd I have not checked. |
Member
|
Why put go files in |
Member
Author
|
Then we should also move all assets into another subfolder |
Member
|
Why? And another thing, now all the golint pass except |
Member
Author
|
Because of package name |
added 7 commits
November 29, 2016 15:24
Member
Author
|
So what's up with it now? I would build the other bindata changes based on that. |
Member
Author
|
Ha, I will try to move the .go files to modules. |
Member
Author
|
I have moved the bindata now into modules/public/ and updated the web cmd as well. This should be fine now, including optional bindata. |
Contributor
|
LGTM :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there have been people crying because of the big bindata PR I'm trying to split it into multiple smaller pull requests. This is the first step which embeds the public folder optionally into the binary with the build tag
bindata. This pull requests obsoletes parts of #74.