Fix mail template error #29410
Merged
Fix mail template error #29410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Feb 26, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Feb 26, 2024
| log.Error("Failed to parse template [%s/body]: %v", name, err) | ||
| if !setting.IsProd { | ||
| log.Fatal("Please fix the mail template error") | ||
| } |
There was a problem hiding this comment.
I'm of the opinion that behaviour differences between RUN_MODE should be kept minimal. Is it warranted here?
There was a problem hiding this comment.
Actually I think it should also "Fatal" (just like web page HTML templates)
But the old code just reports the error message and continues. So I chose to keep the old behavior at the moment.
So I think it is warranted that "the behavior is the same as the old code and the change is minimal", but it doesn't warrant that "the behavior is the same for production/dev"
Feel free to change the behavior.
silverwind
approved these changes
Feb 26, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2024
* giteaofficial/main: Fix mail template error (go-gitea#29410) Document our issue locking policy (go-gitea#29433) Fix htmx rendering the login page in frame on session logout (go-gitea#29405) Ignore empty repo for CreateRepository in action notifier (go-gitea#29416) Fix incorrect tree path value for patch editor (go-gitea#29377) Fix logic error from go-gitea#28138 (go-gitea#29417)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mistake by #29392