Suppress error from monaco-editor #29684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
skip-changelog
silverwind
changed the title
silverwind
commented
Mar 9, 2024
denyskon
approved these changes
Mar 9, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 9, 2024
GiteaBot
added
lgtm/done
|
I fully understand the issue now (see microsoft/vscode#206883) and I think I will just add a error filter to not display this error as there should be no bad outcomes from the error. |
silverwind
changed the title
silverwind
changed the title
|
Rewrote the PR, now it's a simple error filter. |
|
Leaving this open for a bit so people can re-review. |
denyskon
approved these changes
Mar 9, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 11, 2024
* giteaofficial/main: Use repo object format name instead of detecting from git repository (go-gitea#29702) Improve CSV rendering (go-gitea#29638) Remove jQuery AJAX from the comment edit history (go-gitea#29703) fix: rendering internal file links in org (go-gitea#29669) Fix broken webhooks (go-gitea#29690) Suppress error from monaco-editor (go-gitea#29684)
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 13, 2024
Fixes: go-gitea#29414 I see no way for us to catch this error, so downgrade it until microsoft/monaco-editor#4325 is fixed, which will likely take a few weeks to propagate up from vscode. The entries in `updates.config.js` will make [`updates`](https://github.com/silverwind/updates) not upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies.
6543
pushed a commit
that referenced
this pull request
Mar 13, 2024
Backport #29684 by @silverwind Fixes: #29414 I see no way for us to catch this error, so downgrade it until microsoft/monaco-editor#4325 is fixed, which will likely take a few weeks to propagate up from vscode. The entries in `updates.config.js` will make [`updates`](https://github.com/silverwind/updates) not upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies. Co-authored-by: silverwind <[email protected]>
silverwind
added a commit
that referenced
this pull request
Mar 13, 2024
Split out from #29684. This configures the [`updates`](https://github.com/silverwind/updates) module to exclude these modules for reasons stated in the comments.
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 20, 2024
Split out from go-gitea/gitea#29684. This configures the [`updates`](https://github.com/silverwind/updates) module to exclude these modules for reasons stated in the comments. (cherry picked from commit 9b1a8888fa754676073bc851b783b2b8f1adecfb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29414
I see no way for us to catch this error, so downgrade it until microsoft/monaco-editor#4325 is fixed, which will likely take a few weeks to propagate up from vscode.
The entries in
updates.config.jswill makeupdatesnot upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies.