Skip to content

Refactor graceful manager, fix misused WaitGroup #29738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2024
Merged

Refactor graceful manager, fix misused WaitGroup #29738

merged 7 commits into from
Mar 15, 2024

Conversation

forsaken628
Copy link
Contributor

Follow #29629

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 12, 2024
@forsaken628
Copy link
Contributor Author

I have an off topic question. Why was http.Server.Shutdown not used for http graceful shutdown ?

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 12, 2024
@techknowlogick techknowlogick added this to the 1.23.0 milestone Mar 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2024
lng2020
lng2020 approved these changes Mar 14, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2024
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 15, 2024
@lunny
Copy link
Member

lunny commented Mar 15, 2024

I have an off topic question. Why was http.Server.Shutdown not used for http graceful shutdown ?

I think maybe when Gitea start developing, the functions on std library haven't been introduced.

@lunny lunny enabled auto-merge (squash) March 15, 2024 10:33
@lunny lunny merged commit d08f436 into go-gitea:main Mar 15, 2024
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @forsaken628, please send one manually. 🍵

go run ./contrib/backport 29738
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 15, 2024
@6543 6543 removed this from the 1.23.0 milestone Mar 16, 2024
@6543 6543 added this to the 1.22.0 milestone Mar 16, 2024
@lunny lunny removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 19, 2024
@lunny lunny mentioned this pull request Mar 31, 2024
Closed
@wxiaoguang wxiaoguang mentioned this pull request May 7, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@forsaken628 @lunny @GiteaBot @wxiaoguang @lng2020 @techknowlogick @6543