Remove jQuery class from the code range selection#30173
Merged
silverwind merged 2 commits intogo-gitea:mainfrom Mar 29, 2024
Merged
Remove jQuery class from the code range selection#30173silverwind merged 2 commits intogo-gitea:mainfrom
silverwind merged 2 commits intogo-gitea:mainfrom
Conversation
- Switched from jQuery class functions to plain JavaScript `classList` - Tested the code range selection functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
yardenshoham
added
the
type/refactoring
silverwind
reviewed
Mar 29, 2024
| $linesEls.closest('tr').removeClass('active'); | ||
| for (const el of $linesEls) { | ||
| el.closest('tr').classList.remove('active'); | ||
| } |
Member
There was a problem hiding this comment.
Seems a bit unusual to iterate a jQuery collection with for-of, but if it works I can accept it.
silverwind
approved these changes
Mar 29, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 29, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 30, 2024
* giteaofficial/main: Include encoding in signature payload (go-gitea#30174) Add `stylelint-value-no-unknown-custom-properties` and convert stylelint config to js (go-gitea#30117) Remove jQuery class from the commit button (go-gitea#30178) Remove jQuery class from the diff view (go-gitea#30176) Remove jQuery class from the notification count (go-gitea#30172) Remove jQuery class from the code range selection (go-gitea#30173) Fix:the rounded corners of the folded file are not displayed correctly (go-gitea#29953) Add setting to disable user features when user login type is not plain (go-gitea#29615) # Conflicts: # models/user/user.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classList