Fix create commit status #30225
Merged
Fix create commit status #30225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Apr 1, 2024
GiteaBot
added
lgtm/need 1
Contributor
|
I think it should have a proper fix in 1.23 first, then backport. The complete fix #30223 has a migration, I think it should wait till 1.22 stable gets released. |
Member
Author
This is in fact unrelated to that PR. This PR fixed a bug but the aim of that PR is improving the performance. |
wolfogre
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 8, 2024
Partially backport go-gitea#30223 This PR uses the service layer `CreateCommitstatus` method instead of the git model method.
lafriks
pushed a commit
that referenced
this pull request
Apr 8, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 15, 2024
- Backport of go-gitea/gitea#30225 (cherry picked from commit 36f4732)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 15, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially backport #30223
This PR uses the service layer
CreateCommitstatusmethod instead of the git model method.