Refactor web routes#30519
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
refactor-routes
branch
from
d9a0935 to
9192fad
Compare
wxiaoguang
force-pushed
the
refactor-routes
branch
2 times, most recently
from
a94ef9a to
2fd0b7a
Compare
wxiaoguang
force-pushed
the
refactor-routes
branch
3 times, most recently
from
121614e to
a74db6e
Compare
wxiaoguang
force-pushed
the
refactor-routes
branch
from
a74db6e to
9718a2b
Compare
Contributor
Author
|
CI passes, hopefully nothing breaks. Even if there is any regression, it should be easy to fix, and I will fix in first time. This PR is still far from ideal, it is only slightly better than before ..... so I guess there would need more fixes in the future. |
silverwind
approved these changes
Apr 16, 2024
GiteaBot
added
lgtm/need 1
lunny
reviewed
Apr 17, 2024
lunny
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/done
Member
|
per #30519 (comment) |
lunny
approved these changes
Apr 17, 2024
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
delvh
reviewed
Apr 17, 2024
Member
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
Here's my review from before the PR was merged:
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2024
* giteaofficial/main: Add an api test for updating user (go-gitea#30539) [skip ci] Updated translations via Crowdin Expose fuzzy search for issues/pulls (go-gitea#29701) Allow everyone to read or write a wiki by a repo unit setting (go-gitea#30495) Support nuspec manifest download for nuget packages (go-gitea#28921) Fix branch_protection api shows users/teams who has no readAccess (go-gitea#30291) Correct locale string rendering (go-gitea#30522) Run `go generate` and `go vet` on all packages (go-gitea#30529) Fix and tweak pull request commit list (go-gitea#30528) Refactor web routes (go-gitea#30519) Fix install page checkboxes and dropdown width (go-gitea#30526) # Conflicts: # routers/web/user/home.go # templates/user/dashboard/issues.tmpl
lunny
pushed a commit
that referenced
this pull request
Apr 26, 2024
wxiaoguang
added
the
type/refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-organize the routes in web.go and use ctx constants instead of
context.UnitTypes()