Skip to content

Add project column choice option on issue sidebar #30617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Add project column choice option on issue sidebar #30617

wants to merge 12 commits into from

Conversation

a1012112796
Copy link
Member

example:
test

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/js labels Apr 20, 2024
@lunny lunny added this to the 1.23.0 milestone Apr 22, 2024
@lunny
Copy link
Member

lunny commented Apr 23, 2024

A change comment need to be created when switching successfully.

lunny
lunny reviewed Apr 23, 2024
View reviewed changes
lunny
lunny reviewed Apr 23, 2024
View reviewed changes
@a1012112796
Copy link
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

@a1012112796
remove not used code
9207a4e 
Signed-off-by: a1012112796 <[email protected]>
@lunny
Copy link
Member

lunny commented Apr 23, 2024

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

@a1012112796 a1012112796 mentioned this pull request Apr 25, 2024
Closed
@a1012112796
Copy link
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

see #30703, it's not a small change like what you see...

@lunny lunny mentioned this pull request Apr 26, 2024
Merged
7 tasks
@yp05327
Copy link
Contributor

yp05327 commented Apr 30, 2024

Considering multi project support, maybe using modal later is a good choice.

@lunny lunny mentioned this pull request May 7, 2024
Closed
13 tasks
@lunny
Copy link
Member

lunny commented May 28, 2024

Please resolve the conflicts, sorry the rename PR results in conflicts.

@a1012112796
Merge remote-tracking branch 'origin/main' into zzc/dev/sidebar_board…
9b2b4da 
…_option

Signed-off-by: a1012112796 <[email protected]>
@a1012112796
fix nits
85b93b2 
Signed-off-by: a1012112796 <[email protected]>
@a1012112796
fix test
aa91afb 
Signed-off-by: a1012112796 <[email protected]>
lunny
lunny reviewed Jun 3, 2024
View reviewed changes
@a1012112796
rename js
8a98856 
Signed-off-by: a1012112796 <[email protected]>
@a1012112796
rename
7e1b786 
Signed-off-by: a1012112796 <[email protected]>
@lunny lunny changed the title add project board choice option on issue sidebar Add project column choice option on issue sidebar Jun 3, 2024
lunny
lunny reviewed Jun 3, 2024
View reviewed changes
lunny
lunny reviewed Jun 3, 2024
View reviewed changes
models/project/issue.go Outdated
}
defer committer.Close()

num, err := toColumn.NumIssues(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. If you update two columns, then they will have the same sorting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this function only can update one column.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean one by one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean one by one.

I think it okay, becaue when call it one by one, NumIssues also will be canged one by one. else which sorting should be seted in this usage? zero?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks in moveIssuesToAnotherColumn(), it use max() sql function to get new sorting, I have use same logic in a824db0, how about this?

@yp05327
Copy link
Contributor

yp05327 commented Jun 6, 2024

Considering multi project support, maybe using modal later is a good choice.

Announce it again. This PR may cause big conflict in Web UI with #30381.

@yp05327
Copy link
Contributor

yp05327 commented Sep 19, 2024

Fix #13520?

@lunny lunny modified the milestones: 1.23.0, 1.24.0 Oct 10, 2024
@yp05327 yp05327 mentioned this pull request Dec 5, 2024
Closed
@lunny lunny mentioned this pull request Dec 18, 2024
Open
@wxiaoguang wxiaoguang removed this from the 1.24.0 milestone Apr 13, 2025
@wxiaoguang
Copy link
Contributor

This feature is exclusive to "Add support multiple projects again #30381", 30381 has multiple projects binding and there is no dedicated project column.

Only one PR could continue while both of the PRs have numbers of up-voting users. Need to decide. @go-gitea/maintainers

@wxiaoguang wxiaoguang mentioned this pull request Apr 19, 2025
Open
@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 19, 2025
@lunny
Copy link
Member

lunny commented Apr 19, 2025

Maybe we can close this one at the moment to follow what GH did.

@wxiaoguang
Copy link
Contributor

I also agree with that "support multiple projects" seems more intuitive to end users

@wxiaoguang wxiaoguang closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files modifies/translation topic/projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a1012112796 @lunny @yp05327 @wxiaoguang @techknowlogick @GiteaBot