If a repository return no commitstatus, then still cache it but not query it from database #30700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery it from database
lunny
added
performance/speed
GiteaBot
added
the
lgtm/need 2
wolfogre
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 25, 2024
* giteaofficial/main: If a repository return no commitstatus, then still cache it but not query it from database (go-gitea#30700) [skip ci] Updated translations via Crowdin Fix view of readme file in the home code page. (go-gitea#30564) Add test for go-gitea#30674 (go-gitea#30679) Fix border-radius of header+segment boxes (go-gitea#30667)
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 27, 2024
…uery it from database (go-gitea#30700) The previous repository default branch commit status cache will only store if the commit status has value. So the repository which have no any commit status will always be fetched from database. This PR will store the empty state of commit status of a repository into cache because the cache will be updated once there is a commit status stored.
lunny
added
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous repository default branch commit status cache will only store if the commit status has value. So the repository which have no any commit status will always be fetched from database.
This PR will store the empty state of commit status of a repository into cache because the cache will be updated once there is a commit status stored.