Improve logout from worker #30775
Merged
Improve logout from worker #30775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
type/bug
backport/v1.22
lunny
approved these changes
Apr 30, 2024
GiteaBot
added
lgtm/need 1
delvh
reviewed
Apr 30, 2024
|
It does appear to at least fix the issue: 
|
|
What I don't quite understand: Why do we have this |
|
Ah, so it's a multi-tab logout feature, ok. It does seem incorrect to listen for the event twice in both SSE subscriptions, but I guess this whole SSE code is very badly designed and needs a replacement, ideally websocket. |
|
Can confirm it works. Logged out on tab 1, 5 seconds later tab 2 logged out. Maybe the delay is a bit much though. |
It isn't much. Even if there is no logout from the worker, the user is indeed logged out, any new click will just request the page without signed-in account. |
silverwind
reviewed
Apr 30, 2024
silverwind
approved these changes
Apr 30, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 30, 2024
A quick fix for go-gitea#30756
wxiaoguang
added a commit
that referenced
this pull request
Apr 30, 2024
Backport #30775 by wxiaoguang A quick fix for #30756 Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix for #30756