Return access_denied error when an OAuth2 request is denied#30974
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
May 14, 2024
wxiaoguang
reviewed
May 14, 2024
wxiaoguang
reviewed
May 15, 2024
wxiaoguang
approved these changes
May 15, 2024
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Overall LGTM.
I guess the tests would fail because the id is used by htmlDoc.AssertElement(t, "#authorize-app", true), it can't be removed.
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 20, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 20, 2024
…ea#30974) According to [RFC 6749](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1), when the resource owner or authorization server denied an request, an `access_denied` error should be returned. But currently in this case Gitea does not return any error. For example, if the user clicks "Cancel" here, an `access_denied` error should be returned. <img width="360px" src="https://github.com/go-gitea/gitea/assets/15528715/be31c09b-4c0a-4701-b7a4-f54b8fe3a6c5" />
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 21, 2024
* giteaofficial/main: Don't include link of deleted branch when listing branches (go-gitea#31028) [skip ci] Updated translations via Crowdin Refactor sha1 and time-limited code (go-gitea#31023) Return `access_denied` error when an OAuth2 request is denied (go-gitea#30974) Avoid 500 panic error when uploading invalid maven package file (go-gitea#31014) Fix incorrect "blob excerpt" link when comparing files (go-gitea#31013) Fix project column title overflow (go-gitea#31011) Fix data-race during testing (go-gitea#30999)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to RFC 6749, when the resource owner or authorization server denied an request, an
access_deniederror should be returned. But currently in this case Gitea does not return any error.For example, if the user clicks "Cancel" here, an
access_deniederror should be returned.