Refactor sha1 and time-limited code (#31023)#31030
Merged
Merged
Conversation
Remove "EncodeSha1", it shouldn't be used as a general purpose hasher (just like we have removed "EncodeMD5" in go-gitea#28622) Rewrite the "time-limited code" related code and write better tests, the old code doesn't seem quite right.
GiteaBot
added
modifies/go
topic/security
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
May 20, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 20, 2024
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31023 by wxiaoguang
Remove "EncodeSha1", it shouldn't be used as a general purpose hasher (just like we have removed "EncodeMD5" in #28622)
Rewrite the "time-limited code" related code and write better tests, the old code doesn't seem quite right.