Skip to content

Split sanitizer functions and fine-tune some tests (#31192) #31200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wxiaoguang merged 1 commit into from
May 31, 2024
Merged

Split sanitizer functions and fine-tune some tests (#31192) #31200

wxiaoguang merged 1 commit into from
May 31, 2024

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented May 31, 2024

Backport #31192 by @wxiaoguang

  1. Split "sanitizer.go" into small files
  2. Remove unnecessary NewSanitizer and introduce GetDefaultSanitizer
  3. Fine-tune some tests. For example: merge TestSanitizeNonEscape into TestSanitizer: it could simply test what is expected, instead of using Contains

@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality. labels May 31, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone May 31, 2024
@GiteaBot GiteaBot requested review from lunny and silverwind May 31, 2024 13:26
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 31, 2024 13:27
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2024
@wxiaoguang wxiaoguang merged commit b6280f4 into go-gitea:release/v1.22 May 31, 2024
@GoVulnBot GoVulnBot mentioned this pull request Aug 6, 2024
Closed
@cfi-gb
Copy link

cfi-gb commented Aug 6, 2024 •
edited
Loading

CVE-2024-6886 seems to have been assigned for this (At least https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-6886 is referring to this PR)

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@wxiaoguang wxiaoguang

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.22.1

Development

Successfully merging this pull request may close these issues.

4 participants

@GiteaBot @cfi-gb @silverwind @wxiaoguang