Skip to content

For consistency make repo search sort options case sensitive #31951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2024
Merged

For consistency make repo search sort options case sensitive #31951

merged 5 commits into from
Sep 5, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 1, 2024

as title.

smal int missed by #30876

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 1, 2024
@6543 6543 added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/api Concerns mainly the API and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them size/XS modifies/go Pull requests that update Go code labels Sep 1, 2024
@6543 6543 mentioned this pull request Sep 1, 2024
Merged
@6543 6543 added this to the 1.23.0 milestone Sep 1, 2024
delvh
delvh approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here I was thinking you made the result case-insensitive, not only the parameter…

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 1, 2024
@6543 6543 changed the title Make repo search api sort case insensitive Make repo search api sort options case insensitive Sep 1, 2024
wxiaoguang
wxiaoguang requested changes Sep 1, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 1, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 5, 2024
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Sep 5, 2024
@6543 6543 changed the title Make repo search api sort options case insensitive For consistency make repo search sort options case sensitive Sep 5, 2024
@6543 6543 requested a review from wxiaoguang September 5, 2024 10:22
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Sep 5, 2024
@wxiaoguang wxiaoguang merged commit 19af534 into go-gitea:main Sep 5, 2024
26 checks passed
@6543 6543 deleted the make-api-sort-more-robust branch September 5, 2024 12:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf074d2 
* giteaofficial/main:
  Return 404 instead of error when commit not exist (go-gitea#31977)
  For consistency make repo search sort options case sensitive (go-gitea#31951)
  Fix nuget/conan/container packages upload bugs (go-gitea#31967)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/api Concerns mainly the API type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @wxiaoguang @delvh @GiteaBot