Skip to content

Fix dropdown content overflow (#31610) #32250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 31 additions & 9 deletions templates/devtest/fomantic-dropdown.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,16 @@
<div class="default text">empty multiple dropdown</div>
<div class="menu">
<div class="item">item</div>
</div>
</div>
<div class="ui multiple clearable search selection dropdown">
<input type="hidden" value="1">
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
{{svg "octicon-x" 14 "remove icon"}}
<div class="default text">clearable search dropdown</div>
<div class="menu">
<div class="item" data-value="1">item</div>
<div class="item">sm1</div>
<div class="item">sm2</div>
<div class="item">medium1</div>
<div class="item">medium2</div>
<div class="item">large item1</div>
<div class="item">large item2</div>
<div class="item">large item3</div>
<div class="item">very large item test 1</div>
<div class="item">very large item test 2</div>
<div class="item">very large item test 3</div>
</div>
</div>
<div class="ui buttons">
Expand All @@ -50,6 +51,27 @@
</div>
</div>
</div>
<div>
<div class="ui multiple clearable search selection dropdown tw-max-w-[220px]">
<input type="hidden" value="1,2,3,4,5,10">
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
{{svg "octicon-x" 14 "remove icon"}}
<div class="default text">clearable search dropdown</div>
<div class="menu">
<div class="item" data-value="1">item</div>
<div class="item" data-value="2">sm1</div>
<div class="item" data-value="3">sm2</div>
<div class="item" data-value="4">medium1</div>
<div class="item" data-value="5">medium2</div>
<div class="item" data-value="6">large item1</div>
<div class="item" data-value="7">large item2</div>
<div class="item" data-value="8">large item3</div>
<div class="item" data-value="9">very large item test 1</div>
<div class="item" data-value="10">very large item test 2</div>
<div class="item" data-value="11">very large item test 3</div>
</div>
</div>
</div>

<h2>Selection</h2>
<div>
Expand Down
4 changes: 4 additions & 0 deletions web_src/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,10 @@ table th[data-sortt-desc] .svg {
min-width: 0; /* make ellipsis work */
}

.ui.multiple.selection.dropdown {
flex-wrap: wrap;
}

.ui.ui.dropdown.selection {
min-width: 14em; /* match the default min width */
}
Expand Down