Reduce integration test overhead #32475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce overhead of preparing the test Git repos by avoiding unnecessary copying of already existing files.
For non-immediate queues, FlushWithContext takes at least 40ms to verify that all items are processed. Calling this in parallel allows for just a single 40ms delay, instead of 40ms per queue.
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
lunny
approved these changes
Nov 11, 2024
GiteaBot
added
lgtm/need 1
We could make it even faster (without any waiting time). Could I edit your PR to implement my idea? |
I'd be fine with this! |
wxiaoguang
reviewed
Nov 14, 2024
wxiaoguang
reviewed
Nov 14, 2024
wxiaoguang
approved these changes
Nov 14, 2024
GiteaBot
added
lgtm/done
wxiaoguang
force-pushed
the
rb/reduce-integration-test-overhead
branch
from
60c0327 to
ace4671
Compare
wxiaoguang
force-pushed
the
rb/reduce-integration-test-overhead
branch
from
ffb110b to
527c049
Compare
|
Done from my side. |
|
I think these changes look good! |
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 15, 2024
* giteaofficial/main: Fix oauth2 error handle not return immediately (go-gitea#32514) Fix incorrect project page CSS class (go-gitea#32510) Add avif image file support (go-gitea#32508) Reduce integration test overhead (go-gitea#32475) Remove jQuery import from some files (go-gitea#32512) Trim title before insert/update to database to match the size requirements of database (go-gitea#32498) Reimplement GetUserOrgsList to make it simple and clear (go-gitea#32486)
|
Need a following up PR: Improve testing and try to fix MySQL hanging #32515 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In profiling integration tests, I found a couple places where per-test overhead could be reduced:
PrintCurrentTest, invokeFlushWithContextin a parallel.