Fix and refactor markdown rendering #32522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
skip-changelog
wxiaoguang
force-pushed
the
fix-markdown
branch
2 times, most recently
from
36501dc to
195b18d
Compare
wxiaoguang
force-pushed
the
fix-markdown
branch
11 times, most recently
from
5ba7c18 to
c038428
Compare
wxiaoguang
force-pushed
the
fix-markdown
branch
from
c038428 to
ecc4244
Compare
wxiaoguang
changed the title
lunny
reviewed
Nov 15, 2024
wxiaoguang
force-pushed
the
fix-markdown
branch
from
546c01a to
526286b
Compare
github-actions
bot
added
the
modifies/templates
lunny
approved these changes
Nov 16, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
fix-markdown
branch
2 times, most recently
from
d572833 to
ca1a295
Compare
wxiaoguang
force-pushed
the
fix-markdown
branch
from
ca1a295 to
78e1eb8
Compare
Zettat123
approved these changes
Nov 16, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 17, 2024
* giteaofficial/main: Fix basic auth with webauthn (go-gitea#32531) Fix and refactor markdown rendering (go-gitea#32522) Fix large image overflow in comment page (go-gitea#31740) Improve testing and try to fix MySQL hanging (go-gitea#32515) Fix `recentupdate` sorting bugs (go-gitea#32505)
|
Thank you all. :-) |
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Jan 23, 2025
(cherry picked from commit 5eebe1d) Conflicts: models/repo/repo.go models/repo/repo_test.go modules/markup/html.go modules/markup/html_commit.go modules/markup/html_email.go modules/markup/html_emoji.go modules/markup/html_internal_test.go modules/markup/html_issue.go modules/markup/html_link.go modules/markup/html_node.go modules/markup/html_test.go modules/markup/markdown/goldmark.go modules/markup/markdown/markdown_test.go modules/markup/markdown/transform_image.go modules/markup/orgmode/orgmode.go modules/markup/orgmode/orgmode_test.go modules/markup/render.go modules/markup/render_links.go modules/templates/util_render.go modules/templates/util_render_test.go routers/common/markup.go routers/web/feed/convert.go routers/web/repo/wiki.go but a few lines survived and are useful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32521
Clarify the render "metas" meanings and usages
We should use clearly defined meta attributes to control the rendering behavior, instead of guessing "mode!=document" or "metas==nil"
Some existing tests are not right, for example, when rendering wiki, the commit URLs should be parsed. Related tests are also updated.