Skip to content

Add "n commits" link to contributors in contributors graph page - #32799

Merged
lunny merged 7 commits into
go-gitea:mainfrom
changchaishi:add-n-commits-link
Dec 12, 2024
Merged

lunny merged 7 commits into
go-gitea:mainfrom
changchaishi:add-n-commits-link

Conversation

@changchaishi

Copy link
Copy Markdown
Contributor

Fixes Issue #29365 and inherit PR #29429

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2024
Comment thread web_src/js/components/RepoContributors.vue Outdated
Comment thread web_src/js/components/RepoContributors.vue Outdated
Comment thread web_src/js/components/RepoContributors.vue Outdated
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 12, 2024
@lunny

lunny commented Dec 12, 2024

Copy link
Copy Markdown
Member

It's not right when the commits come from the secondary email of the user. But maybe it's hard to resolve it in this PR.

图片

@wxiaoguang

Copy link
Copy Markdown
Contributor

It's not right when the commits come from the secondary email of the user. But maybe it's hard to resolve it in this PR.

Good enough for most cases. For "different email" cases, there are far more existing problems than this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2024
@lunny
lunny enabled auto-merge (squash) December 12, 2024 18:13
@lunny
lunny merged commit c9487a7 into go-gitea:main Dec 12, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 13, 2024
* giteaofficial/main:
  Fix bug of branch/tag selector in the issue sidebar (go-gitea#32744)
  Fix lfs migration (go-gitea#32812)
  Avoid MacOS keychain dialog in integration tests (go-gitea#32813)
  Update actionlint.yaml
  Detect whether action view branch was deleted (go-gitea#32764)
  Add "n commits" link to contributors in contributors graph page (go-gitea#32799)
  Fix "unicode escape" JS error (go-gitea#32806)
  use dedicated runners for release artifacts (go-gitea#32811)
  Make API "compare" accept commit IDs (go-gitea#32801)
  Implement update branch API (go-gitea#32433)
  Fix JS error when dropping a file to a editor without dropzone (go-gitea#32804)
  chore: use errors.New to replace fmt.Errorf with no parameters (go-gitea#32800)
@changchaishi
changchaishi deleted the add-n-commits-link branch December 13, 2024 03:43
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants