Clarify path param naming#32969
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-path-param
branch
from
0456f72 to
adefa63
Compare
lunny
approved these changes
Dec 24, 2024
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Dec 24, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 25, 2024
* giteaofficial/main: demilestone should not include milestone (go-gitea#32923) fix textarea newline handle (go-gitea#32966) Fix Azure blob object `Seek` (go-gitea#32974) Fix maven pom inheritance (go-gitea#32943) Refactor arch route handlers (go-gitea#32972) [skip ci] Updated translations via Crowdin Refactor tmpl and blob_excerpt (go-gitea#32967) Clarify path param naming (go-gitea#32969) Refactor getpatch/getdiff functions and remove unnecessary fallback (go-gitea#32817) Refactor request context (go-gitea#32956)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In history (from some legacy frameworks), both
:nameandnameare supported as path path name,:nameis an alias toname.To make code consistent, now we should only use
namebut not:name.Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them.