Refactor "string truncate" #32984
Merged
Refactor "string truncate" #32984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
wxiaoguang
force-pushed
the
fix-string-truncate
branch
4 times, most recently
from
8bd12cd to
79ff8ee
Compare
wxiaoguang
force-pushed
the
fix-string-truncate
branch
from
79ff8ee to
067119c
Compare
lunny
approved these changes
Dec 25, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Dec 25, 2024
| @@ -14,31 +14,92 @@ const ( | |||
| asciiEllipsis = "..." | |||
| ) | |||
|
|
|||
| func IsLikelySplitLeftPart(s string) bool { | |||
| func IsLikelyEllipsisLeftPart(s string) bool { | |||
There was a problem hiding this comment.
Okay, yeah, I can see now where the leftpart is coming from.
I'm still not certain if we should include that in the method name.
But I guess it's fine for now.
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 27, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Improve Actions test (go-gitea#32883) Support org labels when adding labels by label names (go-gitea#32988) Add `show more` organizations icon in user's profile (go-gitea#32986) Improve "ellipsis string" (go-gitea#32989) Refactor "string truncate" (go-gitea#32984)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfill my promise in #32980 (comment)