Skip to content

fix toggle commit body button ui when latest commit message is long #32997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 29, 2024
Merged

fix toggle commit body button ui when latest commit message is long #32997

merged 7 commits into from
Dec 29, 2024

Conversation

metiftikci
Copy link
Member

@metiftikci metiftikci commented Dec 26, 2024 •
edited
Loading

Before

before

After

after

Edit:

I found an issue on mobile view and changed the code as using flex gap

small

large

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 26, 2024
@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 26, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 26, 2024
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.23 This PR should be backported to Gitea 1.23 labels Dec 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@metiftikci
Copy link
Member Author

found another issue on mobile view. then i changed the code as using flex gap instead of margin

wxiaoguang
wxiaoguang reviewed Dec 27, 2024
View reviewed changes
wxiaoguang
wxiaoguang approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts have been resolved

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
@wxiaoguang wxiaoguang removed the backport/v1.23 This PR should be backported to Gitea 1.23 label Dec 27, 2024
@wxiaoguang
Copy link
Contributor

unable to backport, 1.23 needs a manual fix.

@metiftikci
Copy link
Member Author

unable to backport, 1.23 needs a manual fix.

can we cherry-pick 2050ea2 ?

@wxiaoguang
Copy link
Contributor

unable to backport, 1.23 needs a manual fix.

can we cherry-pick 2050ea2 ?

Yup, just need to create a backport branch from branch 1.23 (I mean this PR is not able to "automatically" backport)

@wxiaoguang wxiaoguang added backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 labels Dec 27, 2024
@metiftikci
Copy link
Member Author

metiftikci commented Dec 27, 2024 •
edited
Loading

looks like flex-text-block need to change

image

Edit:

@wxiaoguang can we use flex-text-inline ?

@wxiaoguang
Copy link
Contributor

@wxiaoguang can we use flex-text-inline ?

Of course if it works. I haven't fully tested the changes .....

@metiftikci
Copy link
Member Author

@wxiaoguang done

@lunny lunny merged commit 94048f3 into go-gitea:main Dec 29, 2024
26 checks passed
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2024
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Dec 29, 2024
wxiaoguang added a commit that referenced this pull request Dec 29, 2024
@wxiaoguang
fix toggle commit body button ui when latest commit message is long (#…
ce64641 
…32997) (#33034)

backport #32997 and #33002
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
dcb2993 
* giteaofficial/main:
  Refactor pagination (go-gitea#33037)
  Test webhook email (go-gitea#33033)
  Fix review code comment avatar alignment (go-gitea#33031)
  Fix templating in pull request comparison (go-gitea#33025)
  Refactor tests (go-gitea#33021)
  [skip ci] Updated translations via Crowdin
  always show assignees on right (go-gitea#33006)
  fix toggle commit body button ui when latest commit message is long (go-gitea#32997)
  Fix and/or comment some legacy CSS problems (go-gitea#33015)
  Refactor comment history and fix content edit (go-gitea#33018)
  Fix bug on activities (go-gitea#33008)
  Refactor arch route handlers (go-gitea#32993)
  fix scoped label ui when contains emoji (go-gitea#33007)
  [skip ci] Updated translations via Crowdin
  De-emphasize signed commits (go-gitea#31160)
  Fix eslint (go-gitea#33002)
  Fix Agit pull request permission check (go-gitea#32999)
  Support for email addresses containing uppercase characters when activating user account (go-gitea#32998)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files topic/ui Change the appearance of the Gitea UI type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@metiftikci @wxiaoguang @delvh @lunny @techknowlogick @GiteaBot