Skip to content

User facing messages for AGit errors #33012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 27, 2025
Merged

User facing messages for AGit errors #33012

merged 9 commits into from
Jan 27, 2025

Conversation

TheFox0x7
Copy link
Contributor

Adds user facing messages to errors when submitting agit pull request
Tries to highlight the returned error more and fixes agit suggestion to create PR on first submission.

Closes: #32965

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Dec 27, 2024
@TheFox0x7
Add error prefix in git remote
7712d78 
Return user facing errors in agit for block and collaborator
@TheFox0x7
fix: agit prompt to create a pull request
2d57d46
@TheFox0x7 TheFox0x7 marked this pull request as ready for review January 23, 2025 23:27
lunny
lunny reviewed Jan 24, 2025
View reviewed changes
@lunny lunny added this to the 1.24.0 milestone Jan 24, 2025
hiifong
hiifong reviewed Jan 24, 2025
View reviewed changes
TheFox0x7
TheFox0x7 commented Jan 24, 2025
View reviewed changes
@TheFox0x7
inline translation keys
2b21cb3 
remove dead conditional check
wxiaoguang
wxiaoguang reviewed Jan 25, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jan 25, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2025
lunny
lunny approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the IsCreatePR in the future PRs.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@lunny lunny enabled auto-merge (squash) January 27, 2025 01:15
@lunny lunny merged commit 6ca91f5 into go-gitea:main Jan 27, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 27, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Better end user visibility for failures in agit PRs
5 participants
@TheFox0x7 @lunny @wxiaoguang @hiifong @GiteaBot