Skip to content

Fix review code comment avatar alignment (#33031) #33032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Dec 29, 2024

Backport #33031 by henrygoodman

Fixes #33017

Fixes go-gitea#33017

Avatar should only have offset if the `Comment` has `Content` or
`Attachment` to align with the speech bubble.

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added the modifies/templates This PR modifies the template files label Dec 29, 2024
@GiteaBot GiteaBot requested review from lunny and wxiaoguang December 29, 2024 11:04
@GiteaBot GiteaBot added this to the 1.23.0 milestone Dec 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 29, 2024 11:05
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2024
@wxiaoguang wxiaoguang merged commit 7f0050c into go-gitea:release/v1.23 Dec 29, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants