Skip to content

Fix templating in pull request comparison (#33025) #33038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #33025 by @TheFox0x7

Adds test for expected behavior

Closes: #33013


I'm not stuck on details being empty - I just don't know what to put in there. Suggestions welcome :)

@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Dec 29, 2024
@GiteaBot GiteaBot requested a review from lunny December 29, 2024 17:25
@GiteaBot GiteaBot added this to the 1.23.0 milestone Dec 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2024
@GiteaBot GiteaBot requested a review from wxiaoguang December 29, 2024 17:25
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 29, 2024 17:27
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2024
@lunny lunny added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2024
@wxiaoguang wxiaoguang merged commit 74159a8 into go-gitea:release/v1.23 Dec 29, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 29, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants