Refactor pull-request compare&create page#33071
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
refactor-compare
branch
from
9bea7a3 to
60a1ad3
Compare
wxiaoguang
added
the
type/refactoring
wxiaoguang
force-pushed
the
refactor-compare
branch
from
60a1ad3 to
26869ff
Compare
delvh
approved these changes
Jan 1, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jan 1, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 2, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin unset XDG_HOME_CONFIG as gitea manages configuration locations (go-gitea#33067) Refactor repo-new.ts (go-gitea#33070) Refactor pull-request compare&create page (go-gitea#33071) feat: link to nuget dependencies (go-gitea#26554) Remove some unnecessary template helpers (go-gitea#33069) Inherit submodules from template repository content (go-gitea#16237) [skip ci] Updated translations via Crowdin feat(action): issue change title notifications (go-gitea#33050) Use project's redirect url instead of composing url (go-gitea#33058) Fix unittest and repo create bug (go-gitea#33061) Fix locale type (go-gitea#33059) Refactor maven package registry (go-gitea#33049) Optimize the installation page (go-gitea#32994) [Feature] Private README.md for organization (go-gitea#32872) Make issue suggestion work for new PR page (go-gitea#33035) Add IntelliJ Gateway's .uuid to gitignore (go-gitea#33052)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code is unnecessarily complex.
Compare by ignoring spaces: https://github.com/go-gitea/gitea/pull/33071/files?diff=unified&w=1
{{if .HasPullRequest}}
{{else if .Repository.IsArchived}}
{{else if $allowCreatePR}}
else of `{{if and .IsSigned .PageIsComparePull}}`