Skip to content

Fix "stop time tracking button" on navbar #33084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2025
Merged

Fix "stop time tracking button" on navbar #33084

merged 2 commits into from
Jan 2, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33083

By the way (something I was working on):

  1. relax color/background-color for more markup elements
  2. fix a command line sentence error

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2025
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS labels Jan 2, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/templates This PR modifies the template files labels Jan 2, 2025
@wxiaoguang wxiaoguang changed the title fix Fix "stop time tracking button" on navbar Jan 2, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 2, 2025
Closed
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2025
@lunny lunny merged commit 9ac536a into go-gitea:main Jan 2, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 2, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Jan 2, 2025

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 33084
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Jan 2, 2025
@wxiaoguang wxiaoguang deleted the fix-stop-watch branch January 3, 2025 01:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 6, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6f15516 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix dropdown menu header and mobile view (go-gitea#33108)
  workflow_dispatch use workflow from trigger branch (go-gitea#33098)
  [skip ci] Updated translations via Crowdin
  Trivial fixes (go-gitea#33103)
  Fix empty git repo handling logic (go-gitea#33101)
  Refactor legacy line-number and scroll code (go-gitea#33094)
  Use `Project-URL` metadata field to get a PyPI package's homepage URL (go-gitea#33089)
  Clean up legacy form CSS styles (go-gitea#33081)
  [skip ci] Updated translations via Crowdin
  add myself to maintainers (go-gitea#33088)
  Make Gitea always use its internal config, ignore `/etc/gitconfig` (go-gitea#33076)
  Fix "stop time tracking button" on navbar (go-gitea#33084)
  Fix bleve fuzziness search (go-gitea#33078)
  Try to fix ACME directory problem (go-gitea#33072)
  Refactor env var related code (go-gitea#33075)
@wxiaoguang wxiaoguang mentioned this pull request Jan 16, 2025
Closed
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Jan 16, 2025
@wxiaoguang
Fix "stop time tracking button" on navbar (go-gitea#33084)
0ea9e29 
Fix go-gitea#33083

By the way (something I was working on):

1. relax color/background-color for more markup elements
2. fix a command line sentence error
@wxiaoguang wxiaoguang mentioned this pull request Jan 16, 2025
Merged
lunny pushed a commit that referenced this pull request Jan 16, 2025
@wxiaoguang
Fix "stop time tracking button" on navbar (#33084) (#33300)
52d2988 
Backport #33084 (no conflict)
Fix #33299, and remove incorrect translations
@lunny lunny added the backport/done All backports for this PR have been created label Feb 5, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Stop time tracking button fails to redirect to the issue page
4 participants
@wxiaoguang @GiteaBot @lunny @delvh